Closed
Bug 289794
Opened 19 years ago
Closed 19 years ago
accesskeys for "Mail" and "News" checkboxes in Default Settings/application section are both "d"; the accesskey "D" is dispalyed if the preferences dialog was opened with a pane other than General
Categories
(Thunderbird :: Preferences, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird1.1
People
(Reporter: steffen.wilberg, Assigned: steffen.wilberg)
Details
(Keywords: access, polish)
Attachments
(1 file)
4.36 KB,
patch
|
mscott
:
review+
|
Details | Diff | Splinter Review |
I'm using a trunk build compiled today on Linux/GTK2. The accesskeys for "Mail" and "News" checkboxes in Preferences->General->Default Settings are both "d". If you click alt+d, the "News" checkbox is toggled. The wrong accesskeys are only displayed if the preferences dialog was opened with a pane other than General. It then looks like this: Mail (D) Check Now News (D) Check Now Steps to reproduce: 1. Open the preferences dialog. 2. Select a pane other than General. 3. Close the preferences dialog and open it again. 4. Select the General pane.
Assignee | ||
Updated•19 years ago
|
Flags: blocking-aviary1.1?
Comment 1•19 years ago
|
||
Hm; I don't have Linux to check with, but in Windows, the trunk builds have a redesigned Options panel (icons along the top) which restructure the 'default' settings. There *is* still an access-key conflict: 'R' is the key for 'RSS' as default, and also for the "Restore Default" button under the Start Page. Under Windows, TB 1.0.2 has no access keys for the 'default' settings.
Assignee | ||
Comment 2•19 years ago
|
||
I'm using a trunk build as well, from April 07 (with e.g. the config editor button in the Advanced options panel). It does look different on Windows. In Linux/GTK2, it looks like described in comment 0. http://lxr.mozilla.org/seamonkey/source/mail/components/preferences/general.xul#81
Assignee | ||
Comment 4•19 years ago
|
||
This patch fixes the problems mentioned in comment 0, comment 1, and provides different accesskeys for the "Check Now" buttons. It also removes two lines which were twice in general.dtd.
Attachment #180780 -
Flags: review?(mscott)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Comment 5•19 years ago
|
||
Comment on attachment 180780 [details] [diff] [review] patch thanks Steffen. Feel free to check this in.
Attachment #180780 -
Flags: review?(mscott) → review+
Assignee | ||
Comment 6•19 years ago
|
||
Checking in mozilla/mail/components/preferences/general.xul; /cvsroot/mozilla/mail/components/preferences/general.xul,v <-- general.xul new revision: 1.2; previous revision: 1.1 done Checking in mozilla/mail/locales/en-US/chrome/messenger/preferences/general.dtd; /cvsroot/mozilla/mail/locales/en-US/chrome/messenger/preferences/general.dtd,v <-- general.dtd new revision: 1.4; previous revision: 1.3 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Flags: blocking-aviary1.1?
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•