Closed
Bug 289796
Opened 20 years ago
Closed 20 years ago
split out the view CSS from calendar.css for reuse in lightning
Categories
(Calendar :: Sunbird Only, defect)
Calendar
Sunbird Only
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: shaver, Assigned: shaver)
Details
Attachments
(2 files)
|
105.95 KB,
patch
|
mvl
:
first-review+
|
Details | Diff | Splinter Review |
|
3.33 KB,
patch
|
pavlov
:
first-review+
|
Details | Diff | Splinter Review |
Including all of calendar.css in Lightning breaks Thunderbird pretty badly, because of conflicts over toolbar CSS and the fact that calendar.css applies some rules to all <treechildren>, so I've split out the parts that apply to the different calendar views. The patch is pretty mechanical; there were some differences between pinstripe and winstripe (like :active vs :hover for some all-day stuff, IIRC) that I didn't want to spend time chasing down, but it does indeed look like some of that stuff could be unified. I'm not sure that Lightning will end up reusing the current sunbird views in the longer term, but I thought this was an improvement to the state of the world for sunbird devs as well, so I'm offering it up instead of just carving out the parts we need into Lightning.
| Assignee | ||
Comment 1•20 years ago
|
||
I @imported the new calendar-views.css into @calendar.css to avoid having to chase down users of it (though I suspect they're few). The requisite jar.mn tweaks are in there too.
Attachment #180282 -
Flags: first-review?(mvl)
| Assignee | ||
Comment 2•20 years ago
|
||
The alternative, of course, is to just copy that calendar-views.css chunk into our theme dirs, and leave it forked until Sunbird has a cleaner story. If anyone would rather I not commit the first patch, I'll happily do that.
Attachment #180283 -
Flags: first-review?(pavlov)
Updated•20 years ago
|
Attachment #180282 -
Flags: first-review?(mvl) → first-review+
| Assignee | ||
Comment 3•20 years ago
|
||
Thanks, committed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Attachment #180283 -
Flags: first-review?(pavlov) → first-review+
Updated•19 years ago
|
QA Contact: gurganbl → sunbird
You need to log in
before you can comment on or make changes to this bug.
Description
•