289797 - remove the Info tab from the bookmarks properties dialog

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Steffen Wilberg]

The bookmarks properties dialogs has three tabs: Info, Schedule, Notify. The
latter two are hidden (bug 253478). So there's only the Info tab left.

The dialog should just display the content of the Info tab, without the tab
itself, because there are no other tabs visible.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This is covered in bug 231695, which was somewhat morphed after bug 253478 was
fixed. I'm all for just using this new, cleaner bug though. The thing is, should
we just rip out the functionality that was ifdefed/commented in bug 253478? I
don't think there are any plans to bring that back anytime soon, seeing as how
few people have missed it.

Comment 2

[Steffen Wilberg]

*** Bug 231695 has been marked as a duplicate of this bug. ***

Comment 3

[Asa Dotzler [:asa]]

I don't think we'd block on this but if you come up with a patch and get it
reviewed in time, we'd consider taking it.

Comment 4

[Worcester12345]

(In reply to comment #3)
> I don't think we'd block on this but if you come up with a patch and get it
> reviewed in time, we'd consider taking it.

Sorry, I was assuming there was a patch from comment #1)

Comment 5

[Alfred Kayser]

I propose to remove the scheduling and notify from the current baseline, as it
is not planned to be fixed for 1.1, and there seems to be no desire to have this
feature.
The 'old code' can be kept around for reimplementation (FF 1.5 or later?).
This saves a lot of code in bookmarkProperties.js and .xul, and .dtd.
If people really want to have scheduling and notify it can be re-implemented,
but it will be different anyway...

Created bug 293574 for the re-implementation of code to be deleted by this one.

Comment 6

[Alfred Kayser]

Attachment: Remove scheduling and notify completely, including the useless 'Info' tab [Checked in: Comment 13]

This shows how much can be removed.

Comment 7

[Worcester12345]

I tried to add "useless-UI" key word, but it wouldn't allow me.

Comment 8

[Asaf Romano (gone)]

Comment on attachment 183147 [details] [diff] [review]
Remove scheduling and notify completely, including the useless 'Info' tab
[Checked in: Comment 13]

Asa isn't a developer, ask vladiir or mconnor.

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 183147 [details] [diff] [review]
Remove scheduling and notify completely, including the useless 'Info' tab
[Checked in: Comment 13]

Works for me; there was originally talk of reintroducing bm scheduling for
1.1/1.5, but it seems like it's best left to an extension.

Comment 10

[Steffen Wilberg]

Comment on attachment 183147 [details] [diff] [review]
Remove scheduling and notify completely, including the useless 'Info' tab
[Checked in: Comment 13]

There's no superreview required for code in browser/ and toolkit/.
http://www.mozilla.org/projects/firefox/review.html
http://www.mozilla.org/projects/toolkit/review.html

Comment 11

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 183147 [details] [diff] [review]
Remove scheduling and notify completely, including the useless 'Info' tab
[Checked in: Comment 13]

I love a patch full of minuses in the morning! a=shaver

Comment 12

[Alfred Kayser]

Who can do the checkin for me? I don't have CVS access, but this patch now has
the needed approvals for checkin into the 1.1a2 release for Firefox...

Thanks in advance, Alfred

Comment 13

[Daniel Brooks [:db48x]]

fix checked in

Comment 14

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change