289819 - certutil -A reports extension not found if file has extra data

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

We've had numerous bugs against NSS since 3.0, all of which complained
that they get error SEC_ERROR_EXTENSION_NOT_FOUND in inappropriate 
circumstances.  The first such error filed (that I can find) was bug 51559.

Here's another one.  Create a file that contains a DER-encoded cert but
also has some extra cruft in the file after the cert.  bug 289817 documents
one way of creating such a file.  Then try to import this cert with 
certutil -A.  The import will fail, reporting error "extension not found",
which is wrong.  The problem is yet-another place that fails to set the
appropriate error code.  Patch forthcoming.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Checking in certread.c;  new revision: 1.10; previous revision: 1.9

Thanks for the review.

Comment 3

[Wan-Teh Chang]

Attachment: Fix a typo in the SEC_ERROR_EXTRA_INPUT error message

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 180385 [details] [diff] [review]
Fix a typo in the SEC_ERROR_EXTRA_INPUT error message

good catch, Wan-Teh.

Comment 5

[Wan-Teh Chang]

Comment on attachment 180385 [details] [diff] [review]
Fix a typo in the SEC_ERROR_EXTRA_INPUT error message

Fix checked in on NSS tip for NSS 3.10.

Checking in SECerrs.h;
/cvsroot/mozilla/security/nss/cmd/lib/SECerrs.h,v  <--	SECerrs.h
new revision: 1.11; previous revision: 1.10
done

Also fixed in the SSL Reference.

Checking in sslerr.html;
/cvsroot/mozilla-org/html/projects/security/pki/nss/ref/ssl/sslerr.html,v  <--
sslerr.html
new revision: 1.12; previous revision: 1.11
done