Resizing a dialog window doesn't cause repaint correctly

VERIFIED FIXED

Status

SeaMonkey
UI Design
P3
normal
VERIFIED FIXED
18 years ago
13 years ago

People

(Reporter: Charles Manske, Assigned: travis)

Tracking

Trunk
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [PDT+])

(Reporter)

Description

18 years ago
1. Start Composer (blank doc ok)
2. Click on the Link button on the toolbar.
3. Click on button that is either "More" or "Fewer" a few times -- the dialog
content changes, but doesn't repaint correctly.

This (and other) dialogs have a More/Fewer button that expands/contracts
the dialog by calling window.sizeToContent. 
When the window size is contracted, "old" bits are not cleared, obscuring 
underlying bits. Besides being ugly, this is potentially very dangerous as
you can click on what appears to be a button (e.g., "OK"), but you are 
really interacting with what is behind the dialog.
I have a researched this thoroughly with Travis, and the fix is trivial:
nsXULWindow::SizeShellTo() is calling nsXULWindow::Size() with the "aRepaint"
param set to PR_FALSE, when it should be PR_TRUE.
(Reporter)

Comment 1

18 years ago
Requesting fixing for beta1
Keywords: beta1
(Assignee)

Comment 2

18 years ago
As cmanske states, I have the fix in hand and reviewed.
Status: NEW → ASSIGNED

Comment 3

18 years ago
Putting on PDT+ radar for beta since fix in hand.
Whiteboard: [PDT+]
(Assignee)

Comment 4

18 years ago
Just waiting on checkin approval.
Whiteboard: [PDT+] → [PDT+] waiting on approval to checkin
(Assignee)

Comment 5

18 years ago
Fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Whiteboard: [PDT+] waiting on approval to checkin → [PDT+]

Comment 6

18 years ago
verified 3/3
Status: RESOLVED → VERIFIED
mid-air collision ? / bugzilla cleanup
Reopening (current State: verfied and no resolution)
Status: VERIFIED → REOPENED
Keywords: beta1 → nsbeta1
fixed
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago17 years ago
Resolution: --- → FIXED
verfied
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.