28985 - Resizing a dialog window doesn't cause repaint correctly

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Charles Manske]

1. Start Composer (blank doc ok)
2. Click on the Link button on the toolbar.
3. Click on button that is either "More" or "Fewer" a few times -- the dialog
content changes, but doesn't repaint correctly.

This (and other) dialogs have a More/Fewer button that expands/contracts
the dialog by calling window.sizeToContent. 
When the window size is contracted, "old" bits are not cleared, obscuring 
underlying bits. Besides being ugly, this is potentially very dangerous as
you can click on what appears to be a button (e.g., "OK"), but you are 
really interacting with what is behind the dialog.
I have a researched this thoroughly with Travis, and the fix is trivial:
nsXULWindow::SizeShellTo() is calling nsXULWindow::Size() with the "aRepaint"
param set to PR_FALSE, when it should be PR_TRUE.

Comment 1

[Charles Manske]

Requesting fixing for beta1

Comment 2

[travis]

As cmanske states, I have the fix in hand and reviewed.

Comment 3

[leger]

Putting on PDT+ radar for beta since fix in hand.

Comment 4

[travis]

Just waiting on checkin approval.

Comment 5

[travis]

Fixed

Comment 6

[Paul MacQuiddy]

verified 3/3

Comment 7

[Matthias Versen [:Matti]]

mid-air collision ? / bugzilla cleanup
Reopening (current State: verfied and no resolution)

Comment 8

[Matthias Versen [:Matti]]

fixed

Comment 9

[Matthias Versen [:Matti]]

verfied