289858 - Expose number of children for a given tree item

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

For tree item accessibles, we don't currently expose the number of children in a
way that is efficient for an AT to get to.

Comment 1

[Aaron Leventhal]

Attachment: Append " with %d" in description field. This is a solution worked out with an AT vendor.

Comment 2

[Aaron Leventhal]

Attachment: Also remove unnecessary value support for tree items and make sure we don't expose this discription for lists implemented with a tree

Comment 3

[[e-mail]]

Comment on attachment 180362 [details] [diff] [review]
Also remove unnecessary value support for tree items and make sure we don't expose this discription for lists implemented with a tree

>+  // Count the number of children
You do know that in general it's not possible to know how many potential
children a collapsed parent has, right? All of these methods just return the
number of visible children.

>+  testRow = mRow;
>+  PRInt32 numChildren = 0;
>+  while (++ testRow < numRows) {
>+    PRInt32 testLevel = 0;
>+    mTreeView->GetLevel(testRow, &testLevel);
>+    if (testLevel != level + 1) {
>+      break;
>+    }
>+    ++ numChildren;
>+  }
This needs to work like the loop for the number of siblings, i.e. you only want
to count the immediate children, and you should only break when the testLevel
<= level.

sr=me with these nits addressed.

Comment 4

[Aaron Leventhal]

Comment on attachment 180362 [details] [diff] [review]
Also remove unnecessary value support for tree items and make sure we don't expose this discription for lists implemented with a tree

Timeless gave r= on IRC.
Neil's nits will be addressed.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 180362 [details] [diff] [review]
Also remove unnecessary value support for tree items and make sure we don't expose this discription for lists implemented with a tree

a=asa

Comment 6

[Aaron Leventhal]

Checking in src/msaa/nsAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsAccessibleWrap.cpp,v  <-- 
nsAccessibleWrap.cpp
new revision: 1.26; previous revision: 1.25
done
Checking in src/msaa/nsXULTreeAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsXULTreeAccessibleWrap.cpp,v  <-- 
nsXULTreeAccessibleWrap.cpp
new revision: 1.5; previous revision: 1.4
done
Checking in src/xul/nsXULTreeAccessible.cpp;
/cvsroot/mozilla/accessible/src/xul/nsXULTreeAccessible.cpp,v  <-- 
nsXULTreeAccessible.cpp
new revision: 1.32; previous revision: 1.31
done
Checking in src/xul/nsXULTreeAccessible.h;
/cvsroot/mozilla/accessible/src/xul/nsXULTreeAccessible.h,v  <-- 
nsXULTreeAccessible.h
new revision: 1.16; previous revision: 1.15
done