289886 - Arrows on buttons in Import dialog not flipped in rtl-language localized build

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P2)

Description

[Simon Montagu :smontagu]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; he-IL; rv:1.8b2) Gecko/20050411 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; he-IL; rv:1.8b2) Gecko/20050411 Firefox/1.0+

The "back" and "next" buttons in a he-IL localized build of Firefox show arrows
pointing in the wrong directions, so "back" looks like "next" and "next" looks
like "back"

Reproducible: Always

Steps to Reproduce:
1. File
2. Import

Actual Results:  
Arrows are the same as in an en_US build

Expected Results:  
Arrows should be reversed

Comment 1

[Simon Montagu :smontagu]

Attachment: Screenshot

Comment 2

[Simon Montagu :smontagu]

Attachment: Screenshot

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Comment 4

[Benjamin Smedberg]

Comment on attachment 180358 [details] [diff] [review]
patch

I want caillon's review of this also, just to make sure that the Gnome stock
icons are generally reversible, or there is not a better way to do this.

Comment 5

[Simon Montagu :smontagu]

For the record, I confirm that the patch fixes the bug.

Comment 6

[Asaf Romano (gone)]

...ccing caillon

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 180358 [details] [diff] [review]
patch

Basically, you want to call gtk_icon_set_render_icon() instead of
gtk_widget_render_icon() in nsIconChannel.cpp and you can pass the direction of
the icon there.

Comment 8

[Simon Montagu :smontagu]

The arrows in menu items with submenus also point in the wrong direction. Is
that a similar problem?

Comment 9

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).

Comment 10

[(no longer active)]

This is fixed on trunk by bug 427021, and since Firefox 1.5 is no longer maintained, I don't think we need to keep this open.