Arrows on buttons in Import dialog not flipped in rtl-language localized build

RESOLVED FIXED in Firefox1.5

Status

()

defect
P2
normal
RESOLVED FIXED
14 years ago
10 years ago

People

(Reporter: smontagu, Assigned: mano)

Tracking

(Blocks 2 bugs, {rtl})

unspecified
Firefox1.5
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed by bug 427021)

Attachments

(3 attachments)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; he-IL; rv:1.8b2) Gecko/20050411 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; he-IL; rv:1.8b2) Gecko/20050411 Firefox/1.0+

The "back" and "next" buttons in a he-IL localized build of Firefox show arrows
pointing in the wrong directions, so "back" looks like "next" and "next" looks
like "back"

Reproducible: Always

Steps to Reproduce:
1. File
2. Import

Actual Results:  
Arrows are the same as in an en_US build

Expected Results:  
Arrows should be reversed
(Reporter)

Comment 1

14 years ago
Posted image Screenshot
(Reporter)

Comment 2

14 years ago
Posted image Screenshot
(Reporter)

Updated

14 years ago
Assignee: bugs → bugs.mano
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firefox1.1

Comment 4

14 years ago
Comment on attachment 180358 [details] [diff] [review]
patch

I want caillon's review of this also, just to make sure that the Gnome stock
icons are generally reversible, or there is not a better way to do this.
Attachment #180358 - Flags: superreview?(caillon)
Attachment #180358 - Flags: review?(benjamin)
Attachment #180358 - Flags: review+
(Reporter)

Comment 5

14 years ago
For the record, I confirm that the patch fixes the bug.
Comment on attachment 180358 [details] [diff] [review]
patch

Basically, you want to call gtk_icon_set_render_icon() instead of
gtk_widget_render_icon() in nsIconChannel.cpp and you can pass the direction of
the icon there.
Attachment #180358 - Flags: superreview?(caillon) → superreview-
(Reporter)

Comment 8

14 years ago
The arrows in menu items with submenus also point in the wrong direction. Is
that a similar problem?

Updated

14 years ago
Blocks: 306980

Comment 9

11 years ago
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl

Comment 10

10 years ago
This is fixed on trunk by bug 427021, and since Firefox 1.5 is no longer maintained, I don't think we need to keep this open.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Depends on: 427021
Resolution: --- → FIXED
Whiteboard: fixed by bug 427021
You need to log in before you can comment on or make changes to this bug.