289925 - BugMeNot extension causes Firefox / Seamonkey to crash [@ JS_StackFramePrincipals]

Status: RESOLVED DUPLICATE of bug 289991

(Core :: Security: CAPS, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050410
Firefox/1.0+
1. New Profile, Install BugMeNot extension
(http://roachfiend.com/archives/2005/02/07/bugmenot/)
2. Start firefox.
3. Observe crash

I know extensions aren't bugzilla problems, but I guess it shouldn't cause
firefox to crash.

TBID TB5003308K, TB5003382Y, TB5004128M

Comment 1

[Steve England [:stevee]]

In Comment 0, User Agent String should read Mozilla/5.0 (Windows; U; Windows NT
5.0; en-US; rv:1.8b2) Gecko/20050411 Firefox/1.0+ 

Comment 2

[Steve England [:stevee]]

BugMeNot extensions works fine in Mozilla/5.0 (Windows; U; Windows NT 5.0;
en-US; rv:1.8b2) Gecko/20050410 Firefox/1.0+ buidsl

Comment 3

[Tony-E]

Confirmed, Talkback Id 5009649

Comment 4

[Matthias Versen [:Matti]]

An extension can always crash firefox, delete files on your hdd, format a
partition ...

This looks like invalid for me but based on the timeframe and the stack I think
it COULD be one of the checkins from BZ (bug 289643 or bug 251354).

CC our Gecko GOD, maybe he knows if this is a valid bug (and not in the extension).

Comment 5

[Gérard Talbot]

Is bug 289941 a duplicate of this bug? Just asking.

Comment 6

[Steve England [:stevee]]

Looks like it Gérard. Same kind of stacktrace. Does it crash with in safemode?

Comment 7

[Gérard Talbot]

>Does it crash with in safemode?
If safemode is the use of the default profile, then no, I do not crash while
using default profile.

Comment 8

[Gérard Talbot]

*** Bug 289941 has been marked as a duplicate of this bug. ***

Comment 9

[Boris Zbarsky [:bzbarsky]]

I've been unable to reproduce this crash, either with my debug Firefox build
(with the patch from bug 289643 applied) or with a nightly Firefox Linux build
from this morning....  So either this is Windows-only or something odd is going
on...

Comment 10

[Boris Zbarsky [:bzbarsky]]

So just to be clear, is this crash consistently reproducible?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Kinda hard to see if it works in safe mode given that safe mode is broken on the
trunk still...

Oh, and I can reproduce.

Comment 12

[Boris Zbarsky [:bzbarsky]]

More questions... all the stacks show us coming through enablePrivilege.  Are
people ever explicitly granting privs to this extension as part of the steps to
reproduce?

Also, anyone have a debugger that they can catch this in?  If so, I'd love to
know; I can then try to debug remotely...

Comment 13

[Boris Zbarsky [:bzbarsky]]

One more thing.  If the crash _is_ consistently reproducible for people, then
perhaps I'm just doing something wrong.  Could someone give me explicit
instructions on how to reproduce starting with the point when I first start
Firefox with a clean profile?  "Explicit" means you should explicitly list every
single mouse click and keystroke that needs to be done....

Comment 14

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050411
Firefox/1.0+
The crash is 100% reproducable for me.

Steps to reproduce:

1. Create a new profile.
2. Go to http://www.extensionsmirror.nl/index.php?showtopic=566 (BugMeNot 0.62
extension)
3. Click on "Install" link at the bottom of the first post.
4. A warning bar at the top of the browser will appear saying "To protect your
computer, firefox prevented the site (www.extensionsmirror.nl) from installing
software on your computer. Click "Edit Options"
5. Click "Allow" to let www.extensionsmirror.nl install extensions
6. Click "Close" to close the "Allowed Sites - Software Installation" window.
7. Click on the "Install" link at the bottom of the first post again.
8. The "Software Installation" dialog appears. Wait for the button to count down
2 seconds, then click "Install Now"
9. Observe the extension installs.
10. Close the "Extension" window
11. Close the browser
12. Start the browser again with the same profile
13. Instant Crash. "firefox.exe has generated errors and will be closed by
Windows. You will need to restart the program. An error log is being created"
message dialog appears, as does Talkback.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Yeah... Those exact steps cause no crash on Linux.  But then again, neither does
the testcase in bug 289991, which crashes reliably on Windows.  I just checked
in a patch for that bug that should probably fix this one too; could people
retest in tomorrow's (Tuesday, April 12) builds?

Comment 16

[Ryan VanderMeulen [:RyanVM]]

(In reply to comment #15)
> Yeah... Those exact steps cause no crash on Linux.  But then again, neither does
> the testcase in bug 289991, which crashes reliably on Windows.  I just checked
> in a patch for that bug that should probably fix this one too; could people
> retest in tomorrow's (Tuesday, April 12) builds?

Just did a build from CVS. Problem's fixed :)

Comment 17

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050412
Firefox/1.0+
I can confirm the crash has gone since bug 289991 was fixed.
Should this bug be resolved fixed, or a dupe of bug 289991?

Comment 18

[Boris Zbarsky [:bzbarsky]]

Duplicate is probably more correct...

*** This bug has been marked as a duplicate of 289991 ***