289942 - download manager file size is signed -- large files wrap negative

Status: VERIFIED DUPLICATE of bug 228968

(Toolkit :: Downloads API, defect)

Description

[Kees Cook]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050325 Firefox/1.0.2 (Debian package 1.0.2-1)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050325 Firefox/1.0.2 (Debian package 1.0.2-1)

If you download a very large file (say, 4G) the download manager's file size
report will wrap negative.  I recommend using "off_t" types.  :)

Reproducible: Always

Steps to Reproduce:
1. Find a >2G file to download
2. Download it
3. Watch download manager

Actual Results:  
File size goes negative.

Expected Results:  
File size continues to grow towards 4G.

Comment 1

[Kees Cook]

Attachment: screen shot of wrapped values

Comment 2

[Reuven Gonen]

can you please attach a link to such a file? they aren't so easy to find you know.

Comment 3

[Kees Cook]

I don't have any good external examples.  This was from my internal network.  If
you set up a web browser locally, and generate a file, you can use that.  I'd
use "dd" to create it:

  dd if=/dev/zero of=bigfile.data bs=1M count=4096

Comment 4

[Reuven Gonen]

(In reply to comment #3)
> I don't have any good external examples.  This was from my internal network.  If
> you set up a web browser locally, and generate a file, you can use that.  I'd
> use "dd" to create it:
> 
>   dd if=/dev/zero of=bigfile.data bs=1M count=4096
> 

i'm using windows so i guess this won't work for me ;) it'll be good if you can
find a testcase, though.

Comment 5

[Matthias Versen [:Matti]]

*** This bug has been marked as a duplicate of 228968 ***

*** This bug has been marked as a duplicate of 228968 ***