289952 - JS Error: mSaveHdr is not defined on RSS Accounts

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Dra Jenic Rycr]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2

Whenever I click on a rss feed I have like mozillazine or newsforge I get this
error in the Javascript Console:
Error: mSaveHdr is not defined
Source File: chrome://messenger/content/msgHdrViewOverlay.js
Line: 415

That line is as follows in the msgHdrViewOverlay.js:
      if (!currentAttachments.length && mSaveHdr)

I am unsure of what it all means but I am guessing it is checking for
attachments in an rss article which has none. This only happens on the rss
subscriptions, switching to its trash can or to any local folders does not
reproduce this. This error is minor since nothing damaging happens that I am
aware of. The program still runs fine and I can still view the articles causing
the error.

Reproducible: Always

Steps to Reproduce:
1.Subscribe to RSS Feed
2.Download atleast one article from it
3.View the list of articles

Actual Results:  
I get the error:
Error: mSaveHdr is not defined
Source File: chrome://messenger/content/msgHdrViewOverlay.js
Line: 415
in the JavaScript Console

Expected Results:  
Not check the article for attachments

Comment 1

[Simon Bünzli]

This should actually be quite simple to patch since the problem consists IMHO
just in the fact that mSaveHdr is actually a property of the messageHeaderSink
object and not globally defined. Mozilla Mail suffers from the same problem
(although there mSaveHdr and this.mSaveHdr are mixed).

According to lxr.mozilla.org, this bug still exists in the trunk (since I don't
use nightlies, I can only confirm it for TB 1.0.x).

Comment 2

[Simon Bünzli]

Attachment: mSaveHdr as property of messageHeaderSink

Comment 3

[Karsten Düsterloh]

Yes, your analysis is right; I reported the respective suite bug 275986 a while
ago. I thought I fixed that there, but obviously I didn't... *g*
Simon, would you mind fixing the suite version, too? :)

Comment 4

[Karsten Düsterloh]

Comment on attachment 190665 [details] [diff] [review]
mSaveHdr as property of messageHeaderSink

Okay, looks good (I should have looked at the patch before commenting ;-) ).
Handing over to David to unburden Scott...

Comment 5

[Karsten Düsterloh]

*** Bug 275986 has been marked as a duplicate of this bug. ***

Comment 6

[Karsten Düsterloh]

Checked in.
Thanks for the patch, Simon!