28996 - Mac browser still displays Wallet items in menu

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[sairuh (rarely reading bugmail)]

as seen on opt mozilla bits, 2000022308.

the following items need to be removed from the mac [native] menu by beta1 --how
feasible would this be?

Tasks > Autofill > Safe Form Fill
Tasks > Autofill > Quick Form Fill
Tasks > Autofill > Capture Form
Tasks > Autofill > Wallet Contents

Comment 1

[sairuh (rarely reading bugmail)]

nomin for beta1

Comment 2

[leger]

Putting on the PDT+ radar for beta1.

Comment 3

[Stephen P. Morse]

Mike Pinkerton, any ideas here?  This works fine on windows and unix.  The way 
the menus are turned off is via javascript under control of a pref.  It's all 
done in tasksOverlay.js (search for walle.enabled).

Comment 4

[Mike Pinkerton (not reading bugmail)]

right, mac menus are always display:none, so this does nothing.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Three options:

1: set disabled attribute to true. this will keep the item there, but it will be 
disabled

2: add a new attribute, such as notYetImplemented that we can check and not build 
the item for on mac

3: remove the element from the content model. very brute force.

(1) is easy. (2) requires additional CSS for win32/linux and code for mac. (3) 
can be done in JS, but i don't know the ramifications.

Comment 6

[Mike Pinkerton (not reading bugmail)]

onCreate is not being called for mac menus either, so we won't see steve's new 
disabled attribute being set.

Comment 7

[Stephen P. Morse]

The onCreate problem that Mike referred to above is bug 27947.

Comment 8

[Stephen P. Morse]

Fix checked in.  And now that pinkerton has checked in a fix for 27947, I can 
close this one out.

Comment 9

[sairuh (rarely reading bugmail)]

oh yeah! verif w/mac moz bits 2000022508.