Closed
Bug 289975
Opened 20 years ago
Closed 20 years ago
Crash when using display:-moz-page-break
Categories
(Core :: Layout, defect, P1)
Core
Layout
Tracking
()
VERIFIED
FIXED
mozilla1.8beta2
People
(Reporter: martijn.martijn, Assigned: bzbarsky)
References
()
Details
(Keywords: crash, regression, testcase, Whiteboard: [FIXr])
Attachments
(1 file)
4.25 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
dbaron
:
approval1.8b2+
|
Details | Diff | Splinter Review |
Follow-up from bug 289967.
The url testcase uses display:-moz-page-break;
This hangs/crashes current trunk build of Mozilla.
This did not crash with Mozilla build 2004102604.
It crashes with Mozilla build 2004102705.
Assignee | ||
Comment 1•20 years ago
|
||
So is there a reason we have this DISPLAY_PAGE_BREAK thing for page-break
frames? Can't we just make them display:inline (or even display:none, but that
could be a little weird)?
If we really need the separate display value, we probably just need to fix
ConstructFrameByDisplay to return null for it.
Your guess is as good as mine...
Assignee | ||
Comment 3•20 years ago
|
||
OK, I tested using display:block (since those are basically replaced-element
blocks), and that works fine. I plan to do just that once the patch for bug
289967 lands (otherwise I'll end up with self-conflicts).
Depends on: 289967
Assignee | ||
Comment 4•20 years ago
|
||
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #180519 -
Flags: superreview?(dbaron)
Attachment #180519 -
Flags: review?(dbaron)
Assignee | ||
Updated•20 years ago
|
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.8beta2
Attachment #180519 -
Flags: superreview?(dbaron)
Attachment #180519 -
Flags: superreview+
Attachment #180519 -
Flags: review?(dbaron)
Attachment #180519 -
Flags: review+
Attachment #180519 -
Flags: approval1.8b2+
Assignee | ||
Updated•20 years ago
|
Assignee | ||
Comment 5•20 years ago
|
||
Fixed
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Whiteboard: [FIXr]
Comment 6•20 years ago
|
||
Verified FIXED using the testcase at
https://bugzilla.mozilla.org/attachment.cgi?id=180422 with build 2005-04-23-05
on Windows XP: no more crash here.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•