289976 - NSS public functions that take nicknames should declare them as const

Status: NEW

(NSS :: Libraries, defect, P2)

Description

[timeless]

Comment 1

[Wan-Teh Chang]

timeless, you are right.  Is this bug affecting your app?

I took a quick look at this and found that fixing this
requires fixing several functions PK11_FindCertFromNickname
passes the nickname argument to.  Nelson, is there anyone
at Sun who you can assign this bug to?

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

This bug was originally about function PK11_FindCertFromNickname, but
it really should apply to all NSS public functions that take nickname
strings as input arguments.  

Function PK11_FindCertFromNickname starts by making a strdup of the
nickname string, so it is not really necessary to force the const
qualifier down to all the functions that it calls.  But that's probably
a good idea anyway.

Comment 3

[timeless]

we have poor code because of this, and it's preventing us from providing decent
patches to mozilla.org.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Unsetting target milestone in unresolved bugs whose targets have passed.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, and this bug has priority 'P2'.
:beurdouche, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Marco Castelluccio [:marco]]

We have modified the bot to only consider P1 as high priority, so I'm cancelling the needinfo here.