289981 - nsBrowserContentHandler.js has wrong constant for NS_BINDING_ABORTED

Status: RESOLVED FIXED

(Firefox :: General, defect, P5)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

62 const NS_BINDING_ABORTED = 0x80020006;

but NS_BINDING_ABORTED is really 0x804b0002

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Darin Fisher]

How do you know that the code really wants NS_BINDING_ABORTED?  Does 0x80020006 correspond to some other defined error code that has specific meaning that some other module may care about?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> How do you know that the code really wants NS_BINDING_ABORTED?  Does 0x80020006
> correspond to some other defined error code that has specific meaning that some
> other module may care about?

It's only used for the call to nsIRequest.cancel in nsIContentHandler's handleContent, given it's name I assumed it was a typo. In-tree, this function is never used, I don't know why this object implements nsIContentHandler.

Comment 4

[Benjamin Smedberg]

The function *is* used in some cases where people are calling nsIURILoader to open URIs.  I probably just expanded the macro incorrectly or something like that when I copied this code from the original C++

Comment 5

[Darin Fisher]

OK, sounds good.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/nsBrowserContentHandler.js; new revision: 1.18;

Comment 7

[Benjamin Smedberg]

Mano, why would this block anything? Does this code bug actually affect anything visible?

Comment 8

[Asaf Romano (gone)]

Wrong bug, sorry for spam.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/nsBrowserContentHandler.js 	1.12.2.8