62 const NS_BINDING_ABORTED = 0x80020006; but NS_BINDING_ABORTED is really 0x804b0002
Assignee: mconnor → gavin.sharp
OS: Linux → All
Hardware: PC → All
Summary: browser.js has wrong constant for NS_BINDING_ABORTED → nsBrowserContentHandler.js has wrong constant for NS_BINDING_ABORTED
Target Milestone: --- → Firefox1.6-
Created attachment 200652 [details] [diff] [review] patch
Attachment #200652 - Flags: review?(bugs.mano)
How do you know that the code really wants NS_BINDING_ABORTED? Does 0x80020006 correspond to some other defined error code that has specific meaning that some other module may care about?
(In reply to comment #2) > How do you know that the code really wants NS_BINDING_ABORTED? Does 0x80020006 > correspond to some other defined error code that has specific meaning that some > other module may care about? It's only used for the call to nsIRequest.cancel in nsIContentHandler's handleContent, given it's name I assumed it was a typo. In-tree, this function is never used, I don't know why this object implements nsIContentHandler.
The function *is* used in some cases where people are calling nsIURILoader to open URIs. I probably just expanded the macro incorrectly or something like that when I copied this code from the original C++
OK, sounds good.
Attachment #200652 - Flags: review?(bugs.mano) → review?(benjamin)
mozilla/browser/components/nsBrowserContentHandler.js; new revision: 1.18;
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Mano, why would this block anything? Does this code bug actually affect anything visible?
Wrong bug, sorry for spam.
Version: Trunk → 2.0 Branch
Target Milestone: Firefox 2 → Firefox 2 alpha1
You need to log in before you can comment on or make changes to this bug.