nsBrowserContentHandler.js has wrong constant for NS_BINDING_ABORTED

RESOLVED FIXED in Firefox 2 alpha1

Status

()

P5
normal
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Biesinger, Assigned: Gavin)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2 alpha1
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

62 const NS_BINDING_ABORTED = 0x80020006;

but NS_BINDING_ABORTED is really 0x804b0002

Updated

14 years ago
Assignee: firefox → mconnor
Assignee: mconnor → gavin.sharp
OS: Linux → All
Hardware: PC → All
Summary: browser.js has wrong constant for NS_BINDING_ABORTED → nsBrowserContentHandler.js has wrong constant for NS_BINDING_ABORTED
Target Milestone: --- → Firefox1.6-
Created attachment 200652 [details] [diff] [review]
patch
Attachment #200652 - Flags: review?(bugs.mano)
Status: NEW → ASSIGNED

Comment 2

13 years ago
How do you know that the code really wants NS_BINDING_ABORTED?  Does 0x80020006 correspond to some other defined error code that has specific meaning that some other module may care about?
(In reply to comment #2)
> How do you know that the code really wants NS_BINDING_ABORTED?  Does 0x80020006
> correspond to some other defined error code that has specific meaning that some
> other module may care about?

It's only used for the call to nsIRequest.cancel in nsIContentHandler's handleContent, given it's name I assumed it was a typo. In-tree, this function is never used, I don't know why this object implements nsIContentHandler.

Comment 4

13 years ago
The function *is* used in some cases where people are calling nsIURILoader to open URIs.  I probably just expanded the macro incorrectly or something like that when I copied this code from the original C++

Comment 5

13 years ago
OK, sounds good.
Whiteboard: [patch-r?]
Priority: -- → P5
Attachment #200652 - Flags: review?(bugs.mano) → review?(benjamin)

Updated

13 years ago
Attachment #200652 - Flags: review?(benjamin) → review+
Whiteboard: [patch-r?]
mozilla/browser/components/nsBrowserContentHandler.js; new revision: 1.18;
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 7

13 years ago
Mano, why would this block anything? Does this code bug actually affect anything visible?
Wrong bug, sorry for spam.
Flags: blocking-aviary2?
mozilla/browser/components/nsBrowserContentHandler.js 	1.12.2.8 
Keywords: fixed1.8.1
Version: Trunk → 2.0 Branch
Target Milestone: Firefox 2 → Firefox 2 alpha1
You need to log in before you can comment on or make changes to this bug.