Closed Bug 289983 Opened 20 years ago Closed 18 years ago

Move nsIGdkPixbufImage from gfx/src/gtk to widget/src/gtk2

Categories

(Core Graveyard :: GFX: Gtk, defect)

Product:
Core Graveyard
Component:
GFX: Gtk
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(2 files)

fix
6.38 KB, patch
caillon
: review+
blizzard
: superreview+
chofmann
: approval1.8b2+
Details | Diff | Splinter Review
Fix include
652 bytes, patch
roc
: review-
roc
: superreview-
Details | Diff | Splinter Review 
It's only implemented and used by GTK2. And having it in gfx/src/gtk makes it
difficult to build GTK2-Cairo. I'll attach a patch.
Attached patch fix — — Splinter Review 
Like so.
Attachment #180429 - Flags: superreview?(blizzard)
Attachment #180429 - Flags: review?(blizzard)
Comment on attachment 180429 [details] [diff] [review]
fix

Assuming, there is a removal of nsIGdkPixbufImage in gfx/src/gtk to accompany
this, r=caillon.  Does it make sense to move the file instead of cvs remove and
cvs add?
Attachment #180429 - Flags: review?(blizzard) → review+
The history is so trivial, we don't need to bother with CVS munging.
Attachment #180429 - Flags: superreview?(blizzard) → superreview+
Comment on attachment 180429 [details] [diff] [review]
fix

simple code reorg to get --with-toolkit=cairo-gtk2 building
Attachment #180429 - Flags: approval1.8b2?
Comment on attachment 180429 [details] [diff] [review]
fix

a=chofmann
Attachment #180429 - Flags: approval1.8b2? → approval1.8b2+
checked in
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Well actually, I checked in to my local cvs-mirror by mistake. Which proceeded
to email bonsai with details of the checkin, despite the fact those changes did
not hit Mozilla CVS. D'OH!
reopening until I really check it in
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
checked in
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Attached patch Fix include — — Splinter Review 
Candidate fix for (shared?) browser bustage.
Comment on attachment 181867 [details] [diff] [review]
Fix include

Can someone take a look at this and tell me if it's required to fix ocean's
build?

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1114509720.16044.gz
Attachment #181867 - Flags: superreview?(roc)
Attachment #181867 - Flags: review?(caillon)
I think you need to fix the REQUIRES in the makefile, not changing the include.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #181867 - Flags: superreview?(roc)
Attachment #181867 - Flags: superreview-
Attachment #181867 - Flags: review?(caillon)
Attachment #181867 - Flags: review-
The patches here were checked in so I'm resolving this bug as fixed.
It looks like nsIGdkPixbufImage is obsolete now though:
http://lxr.mozilla.org/seamonkey/search?string=nsIGdkPixbufImage

-> FIXED
Status: REOPENED → RESOLVED
Closed: 20 years ago → 18 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: