Closed
Bug 289994
Opened 19 years ago
Closed 19 years ago
Need REQUIRES to build canvas
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
Details
Attachments
(1 file)
1.14 KB,
patch
|
shaver
:
review+
shaver
:
superreview+
brendan
:
approval1.8b2+
|
Details | Diff | Splinter Review |
When I --enable-cairo, I fail to build layout because of inaccessible #includes. Patch coming up.
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #180437 -
Flags: superreview?(shaver)
Attachment #180437 -
Flags: review?(shaver)
Comment on attachment 180437 [details] [diff] [review] fix r+sr=shaver
Attachment #180437 -
Flags: superreview?(shaver)
Attachment #180437 -
Flags: superreview+
Attachment #180437 -
Flags: review?(shaver)
Attachment #180437 -
Flags: review+
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 180437 [details] [diff] [review] fix simple build config fix to make canvas build.
Attachment #180437 -
Flags: approval1.8b2?
Comment 4•19 years ago
|
||
Comment on attachment 180437 [details] [diff] [review] fix a=brendan for 1.8b2. /be
Attachment #180437 -
Flags: approval1.8b2? → approval1.8b2+
Assignee | ||
Comment 5•19 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 6•19 years ago
|
||
Hmm.... Wasn't this a duplicate of bug 279908? And isn't the patch there cleaner? And possibly still needed?
Assignee | ||
Comment 7•19 years ago
|
||
Yeah, I guess that's the better fix. I'll leave mine in for now because it does fix the build.
You need to log in
before you can comment on or make changes to this bug.
Description
•