289995 - nsKeyCode::KeyCodeIsModifier is miscoded

Status: RESOLVED INVALID

(Core Graveyard :: Widget: Xlib, defect)

Description

[david avery]

nsKeyCode::KeyCodeIsModifier(KeyCode aKeyCode) should be

nsKeyCode::KeyCodeIsModifier(KeySym aKeySym)
or  it needs to call nsKeyCode::ConvertKeyCodeToKeySym of the keycode

it's only used in onr routine and the needed KeySym is available at the call sites

XK_xxxxxx are KeySym defines

as it exits KeyCodeIsModifier will always return PR_FALSE since
Keycode is a byte and the XK_xxxxx it compares with are 0xFFE1 thru 0xFFEE

not sure what this will do to widget/src/xlib/nsAppShell.cpp ( the caller ) 
since it will short circuit the event precessing, but the comment at the call
site says that's what is supposed to happen

Comment 1

[JP Rosevear [:jpr]]

Xlib is not supported nor is it a target.  Xlib widget code has also been deleted from the tree.