nsKeyCode::KeyCodeIsModifier(KeyCode aKeyCode) should be nsKeyCode::KeyCodeIsModifier(KeySym aKeySym) or it needs to call nsKeyCode::ConvertKeyCodeToKeySym of the keycode it's only used in onr routine and the needed KeySym is available at the call sites XK_xxxxxx are KeySym defines as it exits KeyCodeIsModifier will always return PR_FALSE since Keycode is a byte and the XK_xxxxx it compares with are 0xFFE1 thru 0xFFEE not sure what this will do to widget/src/xlib/nsAppShell.cpp ( the caller ) since it will short circuit the event precessing, but the comment at the call site says that's what is supposed to happen
Xlib is not supported nor is it a target. Xlib widget code has also been deleted from the tree.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.