Closed Bug 289995 Opened 20 years ago Closed 13 years ago

nsKeyCode::KeyCodeIsModifier is miscoded

Categories

(Core Graveyard :: Widget: Xlib, defect)

Product:
Core Graveyard
Component:
Widget: Xlib
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: daa, Assigned: roland.mainz)

Details

nsKeyCode::KeyCodeIsModifier(KeyCode aKeyCode) should be nsKeyCode::KeyCodeIsModifier(KeySym aKeySym) or it needs to call nsKeyCode::ConvertKeyCodeToKeySym of the keycode it's only used in onr routine and the needed KeySym is available at the call sites XK_xxxxxx are KeySym defines as it exits KeyCodeIsModifier will always return PR_FALSE since Keycode is a byte and the XK_xxxxx it compares with are 0xFFE1 thru 0xFFEE not sure what this will do to widget/src/xlib/nsAppShell.cpp ( the caller ) since it will short circuit the event precessing, but the comment at the call site says that's what is supposed to happen
Product: Core → Core Graveyard
Xlib is not supported nor is it a target. Xlib widget code has also been deleted from the tree.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.