290005 - [FIXr]Remove unneeded layout flushes

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

We flush layout in a few places because subdocument frames used to start the
subdocument load in Reflow().  Nowadays they do it in Init(), which means that
it's guaranteed to happen synchronously with content insertion if the content is
getting a frame at all.  Furthermore, it's guaranteed to happen before the XBL
constructors and such run.

Given that, I think the flushes can be quite happily removed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Subdocument for testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase that's not regressed by the patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 180459 [details] [diff] [review]
Proposed patch

sr=jst

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 180459 [details] [diff] [review]
Proposed patch

Requesting approval.  This removes some no-longer-needed flushes from XBL;
might even make things faster...

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 180459 [details] [diff] [review]
Proposed patch

a=asa

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed