Closed
Bug 290005
Opened 20 years ago
Closed 20 years ago
[FIXr]Remove unneeded layout flushes
Categories
(Core :: Layout, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(3 files)
180 bytes,
application/vnd.mozilla.xul+xml
|
Details | |
312 bytes,
application/vnd.mozilla.xul+xml
|
Details | |
2.81 KB,
patch
|
roc
:
review+
jst
:
superreview+
asa
:
approval1.8b2+
|
Details | Diff | Splinter Review |
We flush layout in a few places because subdocument frames used to start the
subdocument load in Reflow(). Nowadays they do it in Init(), which means that
it's guaranteed to happen synchronously with content insertion if the content is
getting a frame at all. Furthermore, it's guaranteed to happen before the XBL
constructors and such run.
Given that, I think the flushes can be quite happily removed.
![]() |
Assignee | |
Comment 1•20 years ago
|
||
![]() |
Assignee | |
Comment 2•20 years ago
|
||
![]() |
Assignee | |
Comment 3•20 years ago
|
||
Attachment #180459 -
Flags: superreview?(jst)
Attachment #180459 -
Flags: review?(roc)
![]() |
Assignee | |
Updated•20 years ago
|
Priority: -- → P2
Summary: Remove unneeded layout flushes → [FIX]Remove unneeded layout flushes
Target Milestone: --- → mozilla1.8beta3
Attachment #180459 -
Flags: review?(roc) → review+
Comment 4•20 years ago
|
||
Comment on attachment 180459 [details] [diff] [review]
Proposed patch
sr=jst
Attachment #180459 -
Flags: superreview?(jst) → superreview+
![]() |
Assignee | |
Updated•20 years ago
|
Summary: [FIX]Remove unneeded layout flushes → [FIXr]Remove unneeded layout flushes
![]() |
Assignee | |
Comment 5•20 years ago
|
||
Comment on attachment 180459 [details] [diff] [review]
Proposed patch
Requesting approval. This removes some no-longer-needed flushes from XBL;
might even make things faster...
Attachment #180459 -
Flags: approval1.8b2?
Comment 6•20 years ago
|
||
Comment on attachment 180459 [details] [diff] [review]
Proposed patch
a=asa
Attachment #180459 -
Flags: approval1.8b2? → approval1.8b2+
![]() |
Assignee | |
Comment 7•20 years ago
|
||
Fixed
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.8beta3 → mozilla1.8beta2
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•