Closed Bug 290005 Opened 20 years ago Closed 20 years ago

[FIXr]Remove unneeded layout flushes

Categories

(Core :: Layout, defect, P2)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(3 files)

We flush layout in a few places because subdocument frames used to start the subdocument load in Reflow(). Nowadays they do it in Init(), which means that it's guaranteed to happen synchronously with content insertion if the content is getting a frame at all. Furthermore, it's guaranteed to happen before the XBL constructors and such run. Given that, I think the flushes can be quite happily removed.
Attached patch Proposed patchSplinter Review
Attachment #180459 - Flags: superreview?(jst)
Attachment #180459 - Flags: review?(roc)
Priority: -- → P2
Summary: Remove unneeded layout flushes → [FIX]Remove unneeded layout flushes
Target Milestone: --- → mozilla1.8beta3
Comment on attachment 180459 [details] [diff] [review] Proposed patch sr=jst
Attachment #180459 - Flags: superreview?(jst) → superreview+
Summary: [FIX]Remove unneeded layout flushes → [FIXr]Remove unneeded layout flushes
Comment on attachment 180459 [details] [diff] [review] Proposed patch Requesting approval. This removes some no-longer-needed flushes from XBL; might even make things faster...
Attachment #180459 - Flags: approval1.8b2?
Comment on attachment 180459 [details] [diff] [review] Proposed patch a=asa
Attachment #180459 - Flags: approval1.8b2? → approval1.8b2+
Fixed
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.8beta3 → mozilla1.8beta2
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: