[FIXr]Remove unneeded layout flushes

RESOLVED FIXED in mozilla1.8beta2

Status

()

P2
normal
RESOLVED FIXED
14 years ago
20 days ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla1.8beta2
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

14 years ago
We flush layout in a few places because subdocument frames used to start the
subdocument load in Reflow().  Nowadays they do it in Init(), which means that
it's guaranteed to happen synchronously with content insertion if the content is
getting a frame at all.  Furthermore, it's guaranteed to happen before the XBL
constructors and such run.

Given that, I think the flushes can be quite happily removed.
(Assignee)

Comment 1

14 years ago
Created attachment 180457 [details]
Subdocument for testcase
(Assignee)

Comment 2

14 years ago
Created attachment 180458 [details]
Testcase that's not regressed by the patch
(Assignee)

Comment 3

14 years ago
Created attachment 180459 [details] [diff] [review]
Proposed patch
Attachment #180459 - Flags: superreview?(jst)
Attachment #180459 - Flags: review?(roc)
(Assignee)

Updated

14 years ago
Priority: -- → P2
Summary: Remove unneeded layout flushes → [FIX]Remove unneeded layout flushes
Target Milestone: --- → mozilla1.8beta3
Comment on attachment 180459 [details] [diff] [review]
Proposed patch

sr=jst
Attachment #180459 - Flags: superreview?(jst) → superreview+
(Assignee)

Updated

14 years ago
Summary: [FIX]Remove unneeded layout flushes → [FIXr]Remove unneeded layout flushes
(Assignee)

Comment 5

14 years ago
Comment on attachment 180459 [details] [diff] [review]
Proposed patch

Requesting approval.  This removes some no-longer-needed flushes from XBL;
might even make things faster...
Attachment #180459 - Flags: approval1.8b2?

Comment 6

14 years ago
Comment on attachment 180459 [details] [diff] [review]
Proposed patch

a=asa
Attachment #180459 - Flags: approval1.8b2? → approval1.8b2+
(Assignee)

Comment 7

14 years ago
Fixed
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.8beta3 → mozilla1.8beta2

Updated

25 days ago
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.