290075 - Thunderbird 1.0.x launches no windows and empty Main Menu

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Tracy Walker [:tracy]]

Seen on Thunderbird branch builds: since 0328 (hadn't tested 1.0.1 branch since
mid March)

regression window: 
2005-03-28-04-aviary1.0.1 works .dmg size = 11M
2005-03-28-18-aviary1.0.1 broken .dmg size = 8.5M
all builds after this date have .dmg size = 8.5 and don't work

-Launch a broken build

the only thing present is the Thunderbird Menu item.  The build never launches.

Comment 1

[Scott MacGregor]

I'm pretty sure we haven't reduced our download size by a 2.5 megabytes on the
1.0.x branch, so that change in size is the likely culprit :)

Comment 2

[Chase Phillips]

The dates map to when I switched hilo from using the old release automation to
the Tinderbox build scripts.  If the filename is of the form
'^thunderbird-mac-MachO\.' it was made using the old release automation.  If the
filename is of the form '^thunderbird-powerpc-apple-darwin7\.8\.0' it was made
using the Tinderbox scripts.

I suppose someone made a change to the release automation that didn't land in
either the Tinderbox scripts or the packaging portion of build config.  Anyone
know of changes made to hilo of that form?

Comment 3

[Tracy Walker [:tracy]]

I just noticed a sliver of a line on my Mac screen.  clicked on it, expanded the
tiny window that opened.  It's a blank window associated to Thunderbird. Just
info for others who might encounter the bug.

Comment 4

[Chase Phillips]

Since we're having a problem with hilo's Thunderbird branch builds, could you
check hilo's Thunderbird trunk builds?  They were switched to using the
Tinderbox scripts at the same time.

Comment 5

[Scott MacGregor]

i don't think the change to using the tinderbox script is working for the 1.0.x
branch builds. You can see by the latest nightly builds that the day we switched
the script is the same day the size fell to 8.5 MB.

[   ] thunderbird-mac-MachO.dmg                 28-Mar-2005 12:01   11M  
[   ] thunderbird-powerpc-apple-darwin7.8.0.dmg 12-Apr-2005 11:38  8.5M  

Looking at the build log, it looks like the branch build is running stuff in
mozilla\mail\config which it should not be doing. That stuff is for windows and
linux only and we invoke that directly for those platforms from mail\installer.

So it's trying to do all this chrome re-packaging which doesn't exist on the
Mac. So I see lots of incorrect build stuff in the log file triggered by this
fact including:

make -C /builds/tinderbox/Tb-Aviary1.0.1/Darwin_7.8.0_Depend/mozilla/mail/installer

+++ making chrome
/builds/tinderbox/Tb-Aviary1.0.1/Darwin_7.8.0_Depend/mozilla/mail/config  =>
../../dist/bin/chrome/mail.jar
	zip warning: ../mail.jar not found or empty

Comment 6

[Scott MacGregor]

hilo's trunk builds work fine. I've been using them daily since the switch.

Comment 7

[Chase Phillips]

(In reply to comment #5)
> i don't think the change to using the tinderbox script is working for the 1.0.x
> branch builds. You can see by the latest nightly builds that the day we switched
> the script is the same day the size fell to 8.5 MB.
> 
> [   ] thunderbird-mac-MachO.dmg                 28-Mar-2005 12:01   11M  
> [   ] thunderbird-powerpc-apple-darwin7.8.0.dmg 12-Apr-2005 11:38  8.5M  

Agreed.  I didn't remove the old automation, just disabled it, so if we need to
we can revert.  I want to fix this in the Tinderbox scripts, though, since
that's our brave old world that we should stay in.

> So it's trying to do all this chrome re-packaging which doesn't exist on the
> Mac. So I see lots of incorrect build stuff in the log file triggered by this
> fact including:
> 
> make -C
/builds/tinderbox/Tb-Aviary1.0.1/Darwin_7.8.0_Depend/mozilla/mail/installer
> 
> +++ making chrome
> /builds/tinderbox/Tb-Aviary1.0.1/Darwin_7.8.0_Depend/mozilla/mail/config  =>
> ../../dist/bin/chrome/mail.jar
> 	zip warning: ../mail.jar not found or empty

That set of lines also appears in hilo's trunk build, which is built using the
Tinderbox scripts and you state works for you.  I'll talk to you offline to get
more background here.

Comment 8

[Chase Phillips]

Trunk build log:

Removing unpackaged files...
cd ../../dist/thunderbird; rm -rf TestGtkEmbed bloaturls.txt codesighs*
elf-dynstr-gc thunderbird-bin.elf thunderbird-config mangle* maptsv* mfc*
mkdepend* msdump* msmap* nm2tsv* nsinstall* regchrome* regxpcom* res/samples
res/throbber shlibsign* winEmbed.exe xpcshell* xpidl* xpt_dump* xpt_link*
dirver* plugins res/arrow.gif res/arrowd.gif res/boatcycle.html res/cmessage.txt
res/dtd res/html res/loading-image.gif res/rdf res/viewer.properties
res/viewsource.css chrome/app-chrome.manifest chrome/US.jar
chrome/chromelist.txt chrome/classic.jar chrome/comm.jar chrome/embed-sample.jar
chrome/en-US.jar chrome/messenger.jar chrome/pipnss.jar chrome/pippki.jar
chrome/toolkit.jar PalmSyncInstall.exe components/libgkplugin.so
components/plugin.xpt components/gkplugin.dll 

Branch build log:

Removing unpackaged files...
cd ../../dist/thunderbird/thunderbird.app/Contents/MacOS; rm -rf TestGtkEmbed
bloaturls.txt codesighs* elf-dynstr-gc thunderbird-bin.elf thunderbird-config
mangle* maptsv* mfc* mkdepend* msdump* msmap* nm2tsv* nsinstall* rebasedlls*
regchrome* regxpcom* res/samples res/throbber shlibsign* winEmbed.exe xpcshell*
xpidl* xpt_dump* xpt_link* dirver* plugins res/arrow.gif res/arrowd.gif
res/boatcycle.html res/cmessage.txt res/dtd res/html res/loading-image.gif
res/rdf res/viewer.properties res/viewsource.css chrome/US.jar
chrome/chromelist.txt chrome/classic.jar chrome/comm.jar chrome/embed-sample.jar
chrome/en-US.jar chrome/messenger.jar chrome/pipnss.jar chrome/pippki.jar
chrome/toolkit.jar PalmSyncInstall.exe components/libgkplugin.so
components/plugin.xpt components/gkplugin.dll 

While both remove a large set of files, note that the aviary branch build
removes these files by changing into
../../dist/thunderbird/thunderbird.app/Contents/MacOS, where the trunk build
removes them by changing into ../../dist/thunderbird.  The file list to be
removed is a set of relative paths that only resolve from within
thunderbird.app/Contents/MacOS.  While the trunk build tries to remove these
files, it fails because it starts in the wrong directory.

Still investigating the make-diskimage error on the trunk.  mscott plans to
modify mail/installer/Makefile.in on the branch and trunk to trim NO_PKG_FILES
so that a smaller set of files is removed.  He will also comment out the call to
make in "../config" which leads to repackaging chrome jars to trim unused files.
 (This step is only intended to make a smaller package on Windows and Linux.)

Comment 9

[Chase Phillips]

The trunk has the following code in xpinstall/packager/Makefile.in:

  ifdef NO_PKG_FILES
    @echo "Removing unpackaged files..."
    cd $(DIST)/$(MOZ_PKG_APPNAME); rm -rf $(NO_PKG_FILES)
  endif

The branch has the following code in that file:

  ifdef NO_PKG_FILES
    @echo "Removing unpackaged files..."
    ifeq ($(MOZ_PKG_FORMAT),DMG)
      cd $(DIST)/$(MOZ_PKG_APPNAME)/$(_APPNAME)/Contents/MacOS; rm -rf
$(NO_PKG_FILES)
    else
      cd $(DIST)/$(MOZ_PKG_APPNAME); rm -rf $(NO_PKG_FILES)
    endif
  endif

If Firefox runs this code while building on the Mac, it may also be failing to
trim out the files listed in the NO_PKG_FILES variable.  I'll check that next.

Comment 10

[Chase Phillips]

(In reply to comment #9)
> If Firefox runs this code while building on the Mac, it may also be failing to
> trim out the files listed in the NO_PKG_FILES variable.  I'll check that next.

I gather Firefox uses toolkit/mozapps/installer/packager.mk instead of
xpinstall/packager/Makefile.in.  On the trunk,
toolkit/mozapps/installer/packager.mk has a provision for MacOS X prior to
removing files listed in NO_PKG_FILES.

Comment 11

[Scott MacGregor]

Attachment: skip the chrome re-packaging step for Mac OS X

This fixes part of the problem. Chase has a fix for the other half which is an
inconsistency between the branch and the trunk (once he fixes that on the
trunk, my patch will be required or the trunk will break).

Now that the tinderbox script calls into mail\installer\Makefile.in, we need to
make this Makefile work for Mac OS X. This means skipping the chrome
repackaging steps. And making sure we don't remove core unpackaged JAR files
like comm.jar by keeping them from the NO_PKG_FILES list.

Comment 12

[Scott MacGregor]

i dont' know why firefox added packager.mk to toolkit and then linked to it to
know enough about whether we should be doing the same....

Comment 13

[Scott MacGregor]

Attachment: better fix

Comment 14

[Chase Phillips]

Comment on attachment 180536 [details] [diff] [review]
better fix

r=[e-mail]

Comment 15

[Scott MacGregor]

btw, I checked this into the trunk yesterday but hilo didn't make any builds
today. Did we kill the build script by accident when we were debugging? The
build log looks like nothing even tried to run. 

Comment 16

[Chase Phillips]

Attachment: change into the correct packaging directory on MacOS X before removing files

Comment 17

[Chase Phillips]

Comment on attachment 180667 [details] [diff] [review]
change into the correct packaging directory on MacOS X before removing files

Part 1 of a Thunderbird build config fix, needed to get trunk into shape for
building using our scripts.

Comment 18

[Chase Phillips]

Comment on attachment 180536 [details] [diff] [review]
better fix

Part 2 of a Thunderbird build config fix, needed to get trunk and aviary1.0.1
branch into shape for building on MacOS X using our scripts.

Comment 19

[Chase Phillips]

(In reply to comment #15)
> btw, I checked this into the trunk yesterday but hilo didn't make any builds
> today. Did we kill the build script by accident when we were debugging? The
> build log looks like nothing even tried to run. 

I stopped hilo's builds until we figured out what was causing the problem.  I'll
start them again now.  Sorry if that threw you off.

Comment 20

[Chase Phillips]

Comment on attachment 180667 [details] [diff] [review]
change into the correct packaging directory on MacOS X before removing files

Landed on the trunk.

Checking in xpinstall/packager/Makefile.in;
/cvsroot/mozilla/xpinstall/packager/Makefile.in,v  <--	Makefile.in
new revision: 1.67; previous revision: 1.66
done

Comment 21

[Chase Phillips]

Attachment: MacOS X NO_PKG_FILES modification for the aviary1.0.1 branch

Carrying over r/sr and branch approval from trunk version.

Comment 22

[Chase Phillips]

Comment on attachment 180673 [details] [diff] [review]
MacOS X NO_PKG_FILES modification for the aviary1.0.1 branch

Landed on the Aviary1.0.1 branch.

Checking in Makefile.in;
/cvsroot/mozilla/mail/installer/Makefile.in,v  <--  Makefile.in
new revision: 1.3.2.5.2.1; previous revision: 1.3.2.5
done

Comment 23

[Chase Phillips]

Tellingly, the critical files have moved to the end of NO_PKG_FILES on MacOS X
builds. :)  From hilo's Aviary-1.0.1 build log yesterday available at
http://tinderbox.mozilla.org/showlog.cgi?log=Aviary-1.0.1/1113452280.27957.gz&fulltext=1.

Removing unpackaged files...
cd ../../dist/thunderbird/thunderbird.app/Contents/MacOS; rm -rf TestGtkEmbed
bloaturls.txt codesighs* elf-dynstr-gc thunderbird-bin.elf thunderbird-config
mangle* maptsv* mfc* mkdepend* msdump* msmap* nm2tsv* nsinstall* rebasedlls*
regchrome* regxpcom* res/samples res/throbber shlibsign* winEmbed.exe xpcshell*
xpidl* xpt_dump* xpt_link* dirver* plugins res/arrow.gif res/arrowd.gif
res/boatcycle.html res/cmessage.txt res/dtd res/html res/loading-image.gif
res/rdf res/viewer.properties res/viewsource.css chrome/chromelist.txt
chrome/embed-sample.jar PalmSyncInstall.exe components/libgkplugin.so
components/plugin.xpt components/gkplugin.dll  chrome/en-US.jar
chrome/messenger.jar chrome/pipnss.jar chrome/pippki.jar chrome/toolkit.jar
chrome/classic.jar chrome/comm.jar chrome/US.jar 

This appears to be because MOZ_WIDGET_TOOLKIT isn't defined in the scope of
mail/installer/Makefile.in.  It appears to be inherited in files from include
$(DEPTH)/config/autoconf.mk (eg, see MOZ_WIDGET_TOOLKIT's use in /Makefile.in,
in /browser/locales/Makefile.in, &c).

Comment 24

[Chase Phillips]

Attachment: Make configure settings available to mail/installer/Makefile.in

Low-risk patch that gives mail/installer/Makefile.in access to configure's
autoconf.mk output.

Comment 25

[Chase Phillips]

Comment on attachment 180715 [details] [diff] [review]
Make configure settings available to mail/installer/Makefile.in

Landed on the trunk:

Checking in mail/installer/Makefile.in;
/cvsroot/mozilla/mail/installer/Makefile.in,v  <--  Makefile.in
new revision: 1.10; previous revision: 1.9
done

Landed on the aviary1.0.1 branch:

Checking in mail/installer/Makefile.in;
/cvsroot/mozilla/mail/installer/Makefile.in,v  <--  Makefile.in
new revision: 1.3.2.5.2.2; previous revision: 1.3.2.5.2.1
done

Comment 26

[Chase Phillips]

Marking fixed.  File size on branch is back to what it should be.  Tracy, can
you verify that the latest Mac branch build works for you as expected?

Comment 27

[Tracy Walker [:tracy]]

verified with Mac branch build on Mac 2005-04-14-10-aviary1.0.1