290087 - Need a database-based test for groups

Status: RESOLVED WONTFIX

(Bugzilla :: Testing Suite, enhancement)

Description

[Max Kanat-Alexander]

Groups right now involves probably our most complex SQL and logic in Bugzilla.
It's really easy to forget something when editing groups code, or to somehow
mess it up.

If we have a test suite, one of the things it really needs to test is
third-level groups. That is:

I am a member of A
  because I am a member of B
    because I am a member of C

I'm a bit worried that we're missing this case a lot of the time in our current
code, just looking over it, but it's hard to be sure without some standard test.

Comment 1

[Joel Peshkin]

fortunately, the only code that needs to understand this in in User.pm and
editusers.cgi, so it should not be necessary to check it all over the place.

Comment 2

[Frédéric Buclin]

I don't see how you expect to check this by looking at the code only. There are way too many ways to write SQL queries. This is the kind of tests which should be done by our QA tests.