290095 - Do not display flag types in show_bug.cgi whose inclusion list is empty

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Frédéric Buclin]

When the inclusion list for a given flag type is empty, flags of this type are
still displayed in show_bug.cgi, but changes are not saved (in fact, these flags
are created but immediately deleted). They should not be displayed at all.

(23:01:40) myk: LpSolit: the flags shouldn't be displayed at all
(23:01:59) myk: "inclusion list empty" == "None/None"

Comment 1

[Frédéric Buclin]

Attachment: replace LEFT JOIN by INNER JOIN, v1

Comment 2

[Joel Peshkin]

Comment on attachment 180523 [details] [diff] [review]
replace LEFT JOIN by INNER JOIN, v1

If this is the logical change you want, then the citeria should also change I
think.	Do you really want to include rows where the product_id is NULL??

Comment 3

[Joel Peshkin]

no, wait... I'm wrong.  NULL means all products.  Missing row means no products.

Comment 4

[Joel Peshkin]

Comment on attachment 180523 [details] [diff] [review]
replace LEFT JOIN by INNER JOIN, v1

r=joel by inspection
I presume you've tested it before you a?

Comment 5

[Frédéric Buclin]

Note that 2.18 is not affected. The logic has been changed on the tip by bug
285555 with no reason.

Comment 6

[Frédéric Buclin]

Checking in Bugzilla/FlagType.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/FlagType.pm,v  <--  FlagType.pm
new revision: 1.15; previous revision: 1.14
done