Do not display flag types in show_bug.cgi whose inclusion list is empty

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
Attachments & Requests
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

2.19.2
Bugzilla 2.20
Bug Flags:
approval +
blocking2.20 +

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
When the inclusion list for a given flag type is empty, flags of this type are
still displayed in show_bug.cgi, but changes are not saved (in fact, these flags
are created but immediately deleted). They should not be displayed at all.

(23:01:40) myk: LpSolit: the flags shouldn't be displayed at all
(23:01:59) myk: "inclusion list empty" == "None/None"
(Assignee)

Updated

13 years ago
Summary: Do know display flag types in show_bug.cgi whose inclusion list is empty → Do not display flag types in show_bug.cgi whose inclusion list is empty
(Assignee)

Comment 1

13 years ago
Created attachment 180523 [details] [diff] [review]
replace LEFT JOIN by INNER JOIN, v1
Assignee: attach-and-request → LpSolit
Status: NEW → ASSIGNED
Attachment #180523 - Flags: review?(myk)
(Assignee)

Updated

13 years ago
Attachment #180523 - Flags: review?(bugreport)
(Assignee)

Updated

13 years ago
Flags: blocking2.20?
Target Milestone: --- → Bugzilla 2.20

Comment 2

13 years ago
Comment on attachment 180523 [details] [diff] [review]
replace LEFT JOIN by INNER JOIN, v1

If this is the logical change you want, then the citeria should also change I
think.	Do you really want to include rows where the product_id is NULL??

Comment 3

13 years ago
no, wait... I'm wrong.  NULL means all products.  Missing row means no products.

Comment 4

13 years ago
Comment on attachment 180523 [details] [diff] [review]
replace LEFT JOIN by INNER JOIN, v1

r=joel by inspection
I presume you've tested it before you a?
Attachment #180523 - Flags: review?(bugreport) → review+
(Assignee)

Updated

13 years ago
Flags: approval?
(Assignee)

Comment 5

13 years ago
Note that 2.18 is not affected. The logic has been changed on the tip by bug
285555 with no reason.
(Assignee)

Updated

13 years ago
Attachment #180523 - Flags: review?(myk)
Flags: blocking2.20?
Flags: blocking2.20+
Flags: approval?
Flags: approval+
(Assignee)

Comment 6

13 years ago
Checking in Bugzilla/FlagType.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/FlagType.pm,v  <--  FlagType.pm
new revision: 1.15; previous revision: 1.14
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.