When the inclusion list for a given flag type is empty, flags of this type are still displayed in show_bug.cgi, but changes are not saved (in fact, these flags are created but immediately deleted). They should not be displayed at all. (23:01:40) myk: LpSolit: the flags shouldn't be displayed at all (23:01:59) myk: "inclusion list empty" == "None/None"
Summary: Do know display flag types in show_bug.cgi whose inclusion list is empty → Do not display flag types in show_bug.cgi whose inclusion list is empty
Created attachment 180523 [details] [diff] [review] replace LEFT JOIN by INNER JOIN, v1
Assignee: attach-and-request → LpSolit
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.20
Comment on attachment 180523 [details] [diff] [review] replace LEFT JOIN by INNER JOIN, v1 If this is the logical change you want, then the citeria should also change I think. Do you really want to include rows where the product_id is NULL??
no, wait... I'm wrong. NULL means all products. Missing row means no products.
Comment on attachment 180523 [details] [diff] [review] replace LEFT JOIN by INNER JOIN, v1 r=joel by inspection I presume you've tested it before you a?
Attachment #180523 - Flags: review?(bugreport) → review+
Note that 2.18 is not affected. The logic has been changed on the tip by bug 285555 with no reason.
Checking in Bugzilla/FlagType.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/FlagType.pm,v <-- FlagType.pm new revision: 1.15; previous revision: 1.14 done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.