290112 - Have a central code module that calls GetVersionEx

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[ArronM (:paper)]

http://lxr.mozilla.org/seamonkey/search?string=GetVersionEx%28%26

We use GetVersionEx on various occasions to get the Windows version we are on
and branch accordingly.  Each module that has this logic ends up having it's own
GetVersionEx(..) call (sometimes multiple for different reasons!).

I propose a global function GetWindowsVersion() which returns a enum specifying
the Windows Version.  The enum would go in order from oldest to newest Windows
version, so that > and < comparisons can be used.  GetVersionEx would only need
to be called once for the entire time of Mozilla.

I'm guessing the best place to put it is in
E:\MozDev\MozNoDebug\mozilla\widget\src\windows, maybe a class named
WindowsOSInfo, with one static function.  More could be added if more OS
information is needed.

Comment 1

[ArronM (:paper)]

sorry, that should read mozilla/widget/src/windows, and not my personal drive
and directories :)

Comment 2

[Rob Arnold [:robarnold]]

This was added to nsWindow.cpp by bug 355789 last August.

http://hg.mozilla.org/mozilla-central/index.cgi/annotate/5981a4c540f2/widget/src/windows/nsWindow.cpp#l345