Closed
Bug 290134
Opened 20 years ago
Closed 14 years ago
The radio group on Mozilla->Mail & Newsgroups->Notification is not lockable
Categories
(SeaMonkey :: Preferences, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: eagle.lu, Unassigned)
Details
Attachments
(2 files)
|
1.25 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
|
1.42 KB,
patch
|
neil
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
reproduce steps:
Lock the radio group in Mozilla->Mail & Newsgroups->Notification by adding
lockPref("mail.biff.play_sound.type",1);
in mozilla.cfg
Expected result:
The radiogroup is disabled (shown in gray)
Actual result:
The radiogroup can still be selected.
Attachment #180564 -
Flags: review?(neil.parkwaycc.co.uk)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 180564 [details] [diff] [review] patch Nits: why did you add the lines so far apart? why did you not lock the url or button?
Attachment #180564 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Modified the patch accroding to Neil's comments
Attachment #180669 -
Flags: superreview?(bzbarsky)
Attachment #180669 -
Flags: review?(neil.parkwaycc.co.uk)
|
||
Comment 4•20 years ago
|
||
Comment on attachment 180669 [details] [diff] [review] a new patch sr=bzbarsky, but could we just come up with a system where the prefwindow itself handles the locking or something? This whack-a-mole is getting a little silly...
Attachment #180669 -
Flags: superreview?(bzbarsky) → superreview+
|
|
||
Updated•20 years ago
|
Attachment #180669 -
Flags: review?(neil.parkwaycc.co.uk) → review+
|
||
Comment 5•17 years ago
|
||
(Filter "spam" on 'prefs-nobody-20080612'.)
Assignee: prefs → nobody
QA Contact: prefs
|
|
||
Comment 6•14 years ago
|
||
[probably fixed by the <prefwindow> rewrite]
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•