290177 - ctrl + pgdown / pgup not switching tab when caret in one-line textbox

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Mathieu Pellerin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050413 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050413 Firefox/1.0+

two nice keyboard shortcut stopped two work in the trunk. CTRL+PGDOWN and
CTRL+PGUP used to move within the opened tabs of a window and it stopped to work
in the recent build (I'ld say not to search behond one week for possible patch
that caused this regression)

Reproducible: Always

Steps to Reproduce:

Comment 1

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050413
Firefox/1.0+
New profile WFM. Except when the caret was in the text box on the google-firefox
homepage, then it didn't work.

Comment 2

[Steve England [:stevee]]

I have a feeling this might be the same kind of regression as bug 290172.
Certainly, with firefox 1.02, CTRL-PGUP and CTRL-PGDN changes tab when a
one-line textbox has focus changes tabs, but in official nightly Mozilla/5.0
(Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050413 Firefox/1.0+ this
is no longer the case.

Comment 3

[Steve England [:stevee]]

OK sorry for all the irrelevent comments. This bug is also present in
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050411
Firefox/1.0+
so it must have regressed before that.

Comment 4

[Steve England [:stevee]]

Steps to reproduce
1. Have two tabs open (eg: this one, and another one)
2. Click in the textbox "summary" so the caret is present in it
3. Press CTRL-PGUP or CTRL PG-DN

Expected: Change tab
Actual: auto-complete is popped

Comment 5

[Ben Fowler]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050413
Firefox/1.0+

Ctrl-PgUp and Ctrl-PgDown still work here!

Comment 6

[Aaron Leventhal]

Ctrl+pageup/pagedown are the keys to open the autocomplete history for a
textfield in IE as well, so that's the standard use of that key in a browser
textfield. I'm not actually sure who implemented that for Firefox, but anyway,
it's by design.

Use Ctrl+Tab and Ctrl+Shift+Tab to switch tabs, or Ctrl+digit.

Comment 7

[Steve England [:stevee]]

I thought it was just PGUP and PGDN that opened the auto-complete history for a
text-field. Certainly it works. With a modifier like CTRL I would expect tab
switching as is the norm throughout firefox when text-fields don't have focus.

Also, in the IE URL bar it is PGUP and PGDN that trigger the auto-complete
history; CTRL+PGUP and CTRL+PGDN do nothing.

Comment 8

[Aaron Leventhal]

Go to www.google.com in IE. Hit Ctrl+pagedown. History opens without selecting
an item.

Reopen this bug if you can prove that only plain PageUp/PageDown should do that,
or that Ctrl+Tab proves unusable for you.

Comment 9

[Steve England [:stevee]]

*** Bug 210435 has been marked as a duplicate of this bug. ***

Comment 10

[Luca M.]

it is VERY annoying that CTRL + PGUP or PGDOWN doesnt' switch tabs.

It should do it. It works on Firefox 1.0.7 but not on branch.

Comment 11

[Mike Goodspeed]

*** Bug 315526 has been marked as a duplicate of this bug. ***

Comment 12

[Jo Hermans]

*** Bug 318901 has been marked as a duplicate of this bug. ***

Comment 13

[zug_treno]

*** Bug 319827 has been marked as a duplicate of this bug. ***

Comment 14

[Misha Kruk]

why is this resolved wontfix?  This is a clear regression from 1.0.7

Comment 15

[Adam Guthrie]

*** Bug 325576 has been marked as a duplicate of this bug. ***

Comment 16

[bugzilla]

I'm also surprised that this is wontfix.  ctrl-shift-tab is a lot less convenient finger-wise than ctrl-pgup.  ctrl-pgup works almost all the time, only in one undocumented instance it now doesn't work.

The official list of Firefox keyboard shortcuts at http://www.mozilla.org/support/firefox/keyboard says that either works, which right now isn't the case.

Comment 17

[Csaba Gabor]

This seems strange to me - filing another Bug report, bugzilla shows me this bug as hot within the last two weeks.  What's up with that?  Anyway, on my FF 1.5.0.2, ctrl+tab functionality works as expected: it cycles through the tabs in my FF window.  And I like it that way.  Seems like this should be updated to Resolved Fixed.  I have caret browsing turned on (F7).

As to Comment #8 ... if you mean going to the address bar, on my IE 6, the history is pulled down by alt+down arrow as it is with Ff (and I would suggest that this is the logical way to extend it to other contexts since there is already a standard).  ctrl+tab is standard Microsoft behaviour for switching tabs, working in Excel and Word going back to forever, and in dialog boxes such as those found in the control panel/Regional and Language Options.  I haven't tried IE 7 yet, but I would expect it to work there, too.

Comment 18

[Tim Connors]

ctrl-pgup/down is a hell of a lot more convenient than ctrl-shift-tab, and you can already pop down the completion history with pgdown (funny, I thought alt-down arrow was the standard in Windows.  I guess the good thing about standards is there are so many to choose from)

Yes, lets emulate everything IE is doing, good and bad, and lets ignore how firefox/mozilla/netscape have been behaving for the last *decade*.

Comment 19

[Jeremy Baron]

In addition to the previously stated convenience factor when going from right to left (less buttons to hold down), another issue is those OS's which use Ctrl-Tab for their own function, i.e. to switch virtual desktops.  This is responsible for a significant loss of productivity when I am browsing.  Also, I don't understand what the reasoning is for not fixing this.

Comment 20

[Mark Pilgrim (inactive)]

Aaron and I have discussed this on IRC and he feels that consistency with IE is not compelling enough to warrant this inconvenience.  I disagree, but I'm reopening this bug at his request.

Comment 21

[Aaron Leventhal]

Yes, I'd prefer:
1) consistency across textfields within Mozilla and on the OS. Alt+up/down and F4 are the keys to open dropdowns. People know those keys, most users don't typically know about ctrl+pageup/pagedown for dropdowns.
2) Ctrl+tab is often used on Linux for "next desktop". Fixing this gives those users a different key combo, which is one of the reasons we had ctrl+pageup/down in the first place
3) And we get a fix for the super-annoying bug 318788 for free. It turns out we also do the dropdown for plain pageup/pagedown

As we fix this we should also make F4 drop down the list. Alt+down already works.

Comment 22

[Jeremy Baron]

*** Bug 350817 has been marked as a duplicate of this bug. ***

Comment 23

[Simon Bünzli]

*** Bug 364566 has been marked as a duplicate of this bug. ***

Comment 24

[mey.wer]

ctrl+tab switches virtual desktops as stated before.
many users want ctrl+pgup/pgdown to switch between tabs.

The best solution would be to do 2 things:

Make ctrl+page_up/down default-behaviour to switch between tabs.

Give possibilities to organise shortcuts for all functions in firefox.

Comment 25

[Jason Spiro]

This bug also happens on my Ubuntu Linux PC [Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1.2) Gecko/20060601 Firefox/2.0.0.2 (Ubuntu-edgy)].  So, you may want to change the OS field of this bug to All.

Comment 28

[[e-mail]]

Attachment: Fix via tabbox capturing

There seem to be at least three approaches to this bug. This is the first.

Comment 29

[[e-mail]]

Attachment: Fix via not stopping propagation

Alternatively we can allow the event to propagate so that tabbox.xml sees it.

The third option is not to process keys if the accelerator modifier is down.
That's likely to be a bigger patch, so I won't write it if one of these gets r+ ;-)

Comment 30

[Neil Deakin]

I do think option 3 is more correct, as the autocomplete should be ignoring modified keys is shouldn't be handling, or should at least not call stopPropagation in that case. I do prefer option 2 over option 1 though.

Comment 32

[Leszek Matok]

Ping?

This hit me with SeaMonkey 2.0a1pre on Linux. Ctrl-Shift-Tab is so awkward I would be too ashamed to propose it to anyone and I can simply press down any arrow key to drop-down the text field (so no need to grab Ctrl-PgUp for that purpose, really).

Also, at least with SeaMonkey, pressing the arrows while being focused on the location bar makes it drop down, but Ctrl-PgUp switches tabs. I see the location bar as just an example of text entry, so this behavior is inconsistent.

Comment 33

[Neil Deakin]

Comment on attachment 283705 [details] [diff] [review]
Fix via not stopping propagation

Clear review requests based on my previous comments.

Comment 34

[[e-mail]]

Attachment: Proposed patch

The two location bar autocomplete implementations differ in their choice of modifiers to ignore so I played safe and ignored all three.

Comment 35

[Damon Sicore (:damons)]

+'ing and marking as P3.

Comment 36

[[e-mail]]

Fix checked in.