290180 - Coverity errors found in toolkit/

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Benjamin Smedberg]

Minor cleanup from errors found by Coverity static-analysis tool in the
toolkit/* directory.

Comment 1

[Benjamin Smedberg]

Attachment: Coverity-detected errors in toolkit/*, rev. 1

These are mainly edge-case OOM errors, but the GetScreenOrigin function is
broken by design and may well be the source of memory leaks, and might actually
be worth taking on the 1.0.x branch... let me know what you think about that.

Comment 2

[Darin Fisher]

Comment on attachment 180589 [details] [diff] [review]
Coverity-detected errors in toolkit/*, rev. 1

>Index: toolkit/components/history/src/nsGlobalHistory.cpp

>+      if (tokenStruct)
>+        aResult.AppendElement((void *)tokenStruct);
>+
>       // reset our state
>       tokenName = tokenValue = nsnull;
>       tokenNameLength = tokenValueLength = 0;


>Index: toolkit/components/passwordmgr/base/nsPasswordManager.cpp

>+          PRUnichar* data = ToNewUnicode(userValue);
>+          if (data)
>+            result->mArray.AppendElement(data);
>         }


These changes are fine, but maybe it would be better to early
return with some error to indicate out of memory?  Or, if that
is just far from convenient, then no problem.


r=darin

Comment 3

[Benjamin Smedberg]

Comment on attachment 180589 [details] [diff] [review]
Coverity-detected errors in toolkit/*, rev. 1

Yeah, there isn't a good way to report errors that does not skip other logic.
Swallowing them looked like the better choice.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 180589 [details] [diff] [review]
Coverity-detected errors in toolkit/*, rev. 1

a=asa

Comment 5

[Benjamin Smedberg]

Fixed on trunk.