Closed Bug 290228 Opened 20 years ago Closed 20 years ago

Make new calendar wizard localizable

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sipaq, Assigned: sipaq)

References

Details

(Keywords: regression)

Attachments

(2 files, 4 obsolete files)

new calendarCreation.dtd file with the strings from the wizard v3
2.77 KB, text/plain
mvl
: first-review+
Details
Patch v3
13.52 KB, patch
mvl
: first-review+
Details | Diff | Splinter Review
Followup from bug 286959. The patch in that bug does include unlocalizable strings. This bug aims to correct that.
marking as regression to get on my list. (and the old dialog was localizable, so it is kind-of a regression :)
Keywords: regression
New file with all the localizable strings. This file will have to be added to all locale directories
Attachment #180880 - Flags: first-review?(mvl)
Attached patch patch v1 (obsolete) — — Splinter Review
Attachment #180881 - Flags: first-review?(mvl)
Attachment #180880 - Attachment is obsolete: true
Attachment #180880 - Flags: first-review?(mvl)
Attachment #180881 - Attachment is obsolete: true
Attachment #180881 - Flags: first-review?(mvl)
Attachment #180892 - Flags: first-review?(mvl)
Attached patch patch v2 (obsolete) — — Splinter Review
Attachment #180893 - Flags: first-review?(mvl)
Comment on attachment 180892 [details] new calendarCreation.dtd file with the strings from the wizard v2 "Name:" should be moved to a shared place too, with "WebDAV" etc. r=mvl with that.
Attachment #180892 - Flags: first-review?(mvl) → first-review+
Comment on attachment 180893 [details] [diff] [review] patch v2 (including all the other locales isn't needed. It can be done automaticly) >Index: resources/locale/en-US/calendar.dtd >+<!ENTITY calendarproperties.webdav.label "WebDAV:"> drop the colon there. r=mvl with that changed
Attachment #180893 - Flags: first-review?(mvl) → first-review+
New calendarCreation.xul with mvl's review comments incorporated
Attachment #180892 - Attachment is obsolete: true
Attached patch Patch v3 — — Splinter Review
New (and hopefully) final patch with mvl's review comments incorporated
Attachment #180893 - Attachment is obsolete: true
Attachment #182343 - Flags: first-review+
Attachment #182344 - Flags: first-review+
patch checked in (with some changes to make it actually run, like <description/> -> </description>)
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 182344 [details] [diff] [review] Patch v3 >+ locale/en-US/calendar/calendarCreation.dtd (locale/en-US/calendarCreation.dtd) This didn't seem make it in with the commit. I guess it was in the previous attachment. You can include new files with cvs diff -N.
*** Bug 292811 has been marked as a duplicate of this bug. ***
Oops. checked in the file now.
QA Contact: gurganbl → sunbird
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: