290253 - A repeat won't reflect instance nodes added by script

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

If you use javascript to add another instance node to the instance document that
matches a nodeset specified on a repeat and then rebuild, recalculate,
revalidate and refresh the model, the repeat still won't be updated.  This works
on formsPlayer and the Novell plugin.

With my quick debug, it looks like this is probably caused because
mControlsNeedingRefresh gets cleared by rebuild so the nsXFormsRepeatElement
won't refresh, even though it rebinds.

Comment 1

[aaronr]

Attachment: testcase that shows the problem

after the page loads, click on the button labeled, "click on me to insert a new
node into the instance data".  This will instert a node with a value of 3000 as
the first child of the root element contained in the instance document used by
this repeat element.

Comment 2

[Allan Beaufour]

Attachment: Simpler testcase

I haven't investigated it further, but here's a simpified version of the
testcase.

Comment 3

[Allan Beaufour]

Ahem, I could possibly start by fixing insert/delete functionality first :)

My guess is that either bug 278368 or bug 284469 is to blame.

Comment 4

[Allan Beaufour]

Attachment: insert example

Does not work either...

Comment 5

[Allan Beaufour]

Attachment: Patch

Two problems:
1) Repeats were not bound to the model
2) Rebuild needed to trigger a refresh of everything

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 180716 [details] [diff] [review]
Patch


>-    mDocumentLoaded(PR_FALSE)
>+    mDocumentLoaded(PR_FALSE),
>+    mJustRebuilt(PR_FALSE)

Maybe call this mNeedsRefresh

Other than that, looks ok.
r=me

Comment 7

[aaronr]

Nice!  With smaug's nit included, r=me

Comment 8

[Allan Beaufour]

Checked in.