290308 - Add expression to a few error messages

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

Some of the error messages needs to have the expression generating the error
appended to them.

Comment 1

[Allan Beaufour]

Attachment: Patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 180699 [details] [diff] [review]
Patch

>    */
>   static NS_HIDDEN_(already_AddRefed<nsIDOMXPathResult>)
>-    EvaluateXPath(const nsAString        &aExpression,
>+    EvaluateXPath(const nsString         &aExpression,

Why this change?

>-exprEvaluateError    = XForms Error (10): Error evaluating XPath expression: %S
>-noModelError         = XForms Error (11): Could not find model for element
>+exprEvaluateError    = XForms Error (10): Error parsing XPath expression: %S
>+exprEvaluateError    = XForms Error (11): Error evaluating XPath expression: %S

Shouldn't the first 'exprEvaluateError' be 'exprParseError'

Comment 3

[Allan Beaufour]

(In reply to comment #2)
> (From update of attachment 180699 [details] [diff] [review] [edit])
> >    */
> >   static NS_HIDDEN_(already_AddRefed<nsIDOMXPathResult>)
> >-    EvaluateXPath(const nsAString        &aExpression,
> >+    EvaluateXPath(const nsString         &aExpression,
> 
> Why this change?

nsAString does not have .get(). I could also do a PromiseFlatString on the
nsAString() or something? Strings still puzzle me...

> >-exprEvaluateError    = XForms Error (10): Error evaluating XPath expression: %S
> >-noModelError         = XForms Error (11): Could not find model for element
> >+exprEvaluateError    = XForms Error (10): Error parsing XPath expression: %S
> >+exprEvaluateError    = XForms Error (11): Error evaluating XPath expression: %S
> 
> Shouldn't the first 'exprEvaluateError' be 'exprParseError'

Indeed it should.

Comment 4

[Allan Beaufour]

Attachment: w/smaug's comments

Comment 5

[Allan Beaufour]

Attachment: and now hopefully without dangling pointers...

Comment 6

[Allan Beaufour]

Attachment: here we go again

Here we go again, forgot to rerun diff before uploading :(

Comment 7

[Allan Beaufour]

doron, could you do 2nd review and eventually check it in?

Comment 8

[Doron Rosenberg (IBM)]

r=me, no time to check it in today though.

Comment 9

[Allan Beaufour]

Checked in