290366 - JavaScript error in productmenu.js from editflagtypes.cgi and request.cgi when only one product defined

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

A fresh Bugzilla tip install generates the following error in the JavaScript
console if I go to editflagtypes.cgi and click "Create Flag Type for Bugs":

Error: b has no properties
Source File: http://localhost/bztipb/productmenu.js
Line: 112

Comment 1

[Teemu Mannermaa (:wicked)]

Looks like this error occurs when only one product is defined. It also affects
request.cgi under same condition. Culprit is line 249 of productmenu.js that
assumes there are atleast two items in the array. I don't think we should end up
there when there is only one array item. Note that the updateSelect function in
js/productform.js seems to work so ultimate solution would be to fix bug 258647.

Comment 2

[Teemu Mannermaa (:wicked)]

Attachment: Simple fix, V1

This patch fixes the reported problem and similar problem when there are no
products defined. This results in error "a has no properties" on same line. I
tested this with zero products, one product, one product with one or more
components and two products with different amount of components.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 189787 [details] [diff] [review]
Simple fix, V1

Looks good, r=myk

Comment 4

[Frédéric Buclin]

Checking in productmenu.js;
/cvsroot/mozilla/webtools/bugzilla/productmenu.js,v  <--  productmenu.js
new revision: 1.3; previous revision: 1.2
done