290402 - Functions to support reading-in a Schema object from the database

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement, P1)

Description

[Max Kanat-Alexander]

Right now bug 287986 has an r+ patch on it, but there are also going to be a lot
of other patches that I want to check in that depend on code that is only *part*
of bug 287986.

bug 287986 cannot be checked in right now, because it requires bug 285722 also
being ready.

The code that I want to write will *block* bug 285722.

So, it would be easier for everybody concerned if we check in parts of bug
287986 now, to avoid long dependency trees during patch reviews. :-)

Comment 1

[Max Kanat-Alexander]

Attachment: As much of bug 287986 as can be checked-in now

OK, I just took my text editor to the diff, and cut out all the parts of bug
287986 (attachment 180003 [details] [diff] [review]) that can't be checked-in now.

I've confirmed that checking-in this patch currently makes no change to the
functionality of Bugzilla, but does provide me with the functions that I will
need for other code.

Comment 2

[Tomas Kopal]

Comment on attachment 180755 [details] [diff] [review]
As much of bug 287986 as can be checked-in now

>@@ -1696,6 +1741,11 @@
> 
>     my ($self, $table, $name, $definition) = @_;
> 
>+    if ( exists $self->{abstract_schema}{$table}
>+         && !exists $self->{abstract_schema}{$table}{INDEXES} ) {
>+        $self->{abstract_schema}{$table}{INDEXES} = [];
>+    }
>+

You may want to use the new $self->get_table_abstract($table) here to simplify
this.

>+    #print "$table.$col_name: " . Data::Dumper->Dump([$column]) . "\n";
>+

And you may want to remove this before checkin.

Otherwise it's ok (by inspection).

Comment 3

[Max Kanat-Alexander]

Attachment: Fix bitrot

Just a bitrot fix and a one-character change in the POD docs. Carrying forward
r+.

Comment 4

[Max Kanat-Alexander]

Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.47; previous revision: 1.46
done
Checking in Bugzilla/DB/Mysql.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Mysql.pm,v  <--  Mysql.pm
new revision: 1.14; previous revision: 1.13
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.23; previous revision: 1.22
done
Checking in Bugzilla/DB/Schema/Mysql.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema/Mysql.pm,v  <--  Mysql.pm
new revision: 1.7; previous revision: 1.6
don