290403 - Slight cleanup of Bugzilla::DB index code

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement, P2)

Description

[Max Kanat-Alexander]

This is part of bug 285722. I'm going to add a bz_add_index_raw and
bz_drop_index_raw to eliminate a lot of code duplication inside of the
index-renaming code, and in case we ever need these functions again anyhow.

Comment 1

[Max Kanat-Alexander]

Attachment: Index Cleanup

OK, this is a pretty simple patch. No real functionality change, except that
the messages printed when the index-renaming drops indexes have changed,
slightly.

It's just a code cleanup, for the most part.

Comment 2

[Tomas Kopal]

Comment on attachment 180757 [details] [diff] [review]
Index Cleanup

>-        my @statements = $self->_bz_real_schema->get_add_index_ddl(
>-            $table, $name, $definition);
>+    my @statements = $self->_bz_schema->get_add_index_ddl(
>+        $table, $name, $definition);

>-        my @statements = $self->_bz_real_schema->get_drop_index_ddl(
>-            $table, $name);
>+    my @statements = $self->_bz_schema->get_drop_index_ddl(
>+        $table, $name);

There is a change in functionality. It's r+ if you explain why you are changing
_bz_real_schema to _bz_schema here. Frankly, I am not clear if it makes
difference or not :-(.

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> There is a change in functionality. It's r+ if you explain why you are changing
> _bz_real_schema to _bz_schema here. Frankly, I am not clear if it makes
> difference or not :-(.

  Yeah, it doesn't make a different. It always should have been _bz_schema. The
problem is that when _raw functions are being called, there's a good chance that
_bz_real_schema doesn't actually exist in the DB yet.

Comment 4

[Tomas Kopal]

Comment on attachment 180757 [details] [diff] [review]
Index Cleanup

(In reply to comment #3)
> (In reply to comment #2)
> > There is a change in functionality. It's r+ if you explain why you are changing
> > _bz_real_schema to _bz_schema here. Frankly, I am not clear if it makes
> > difference or not :-(.
> 
>   Yeah, it doesn't make a different. It always should have been _bz_schema. The
> problem is that when _raw functions are being called, there's a good chance that
> _bz_real_schema doesn't actually exist in the DB yet.

OK, makes sense.

Comment 5

[Max Kanat-Alexander]

Attachment: Bitrot fix against bug 290402 (use -p1)

I realized that the checkin of bug 290402 would bitrot this patch, so I fixed
the bitrot in advance. This now depends on bug 290402. :-)

Comment 6

[Max Kanat-Alexander]

Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.48; previous revision: 1.47
done
Checking in Bugzilla/DB/Mysql.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Mysql.pm,v  <--  Mysql.pm
new revision: 1.15; previous revision: 1.14
done