290421 - Suite context menu code shouldn't rely on localname tests

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The Seamonkey context menu code uses the localName of DOM nodes to identify the
type of node.  It should just use the appropriate |instanceof| tests instead. 
For example, replace:

296             } else if ( this.target.localName.toUpperCase() == "TEXTAREA" ) {
297                  this.onTextInput = true;
298             } else if ( this.target.localName.toUpperCase() == "HTML" ) {

with:

  } else if ( this.target instanceof HTMLTextAreaElement ) {
      this.onTextInput = true;
  } else if ( this.target instanceof HTMLHtmlElement ) {

etc.  As things stand, the code behaves incorrectly for XML documents, and the
existing code may even be subject to spoofing or security issues (see bug 290324
for an example, though with an extension).

Comment 1

[Serge Gautherie (:sgautherie)]

In which version/file is this code ?

Comment 2

[Philip Chee]

FIXED by patch in Bug 298892