290433 - Possible misuse of sizeof() in control_kicker.cpp

Status: RESOLVED INVALID

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[David Gardiner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2

Running PREFast static code analysis gave this warning:

control_kicker.cpp(316) : warning 260: Sizeof * sizeof is almost always wrong:
261 * 1. Was a character count or a byte count intended ?
problem occurs in function 'FixupInProcRegistryEntry'

The 3rd parameter of GetModuleFileName is supposed to be the size of the buffer
in TCHARs.

The szMozCtlXLongPath array is already of type TCHAR so when we do a sizeof() we
don't need to multiply - we need to divide.


Reproducible: Always

Steps to Reproduce:



Expected Results:  
I think that this code should probably be something like:

sizeof(szMozCtlXLongPath) / sizeof(TCHAR));

instead.

-dave

Comment 1

[David Gardiner]

Attachment: divide instead of multiply

This should fix it - i'm not sure how to test that code though. Suggestions
welcome.

-dave

Comment 2

[Ed Morley [:emorley]]

The ActiveX embedding API was removed in bug 662023 and friends, making this INVALID.

[Filter bugspam on activexinvalid]