290511 - Move RemoveVotes out of globals.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

Votes are related to bugs and then this function should go into Bug.pm. I need
to work on this function as part of fixing bug 34172, so this is a good
opportunity to do the move.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Move RemoveVotes() from globals.pl to Bug.pm. No fonctionality change.

Comment 2

[Max Kanat-Alexander]

Comment on attachment 180842 [details] [diff] [review]
patch, v1

OK. Eventually this should become a method of the Bug object. (So it's OK that
it stays TitleCaseNamed for now.) 

I'm a little concerned about the circular dependency between BugMail and Bug
that will arise, but that's OK for now, I suppose.

Comment 3

[Dave Miller [:justdave]]

circular dependencies are evil.  But as long as it works, we'll clean those up
when we do the final run of attacks for mod_perl.

Comment 4

[Frédéric Buclin]

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.80; previous revision: 1.79
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.320; previous revision: 1.319
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.74; previous revision: 1.73
done