290572 - Spidermonkey shell does not start on Windows: assertion failure in line 2408 in jsstr.c

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Martin Honnen]

After pulling the latest changes for Spidermonkey via CVS the shell js.exe
builds fine but on start up crashes with the message

  Assertion failure: !rt->emptyString, at jsstr.c:2408

This is probably a regression of the fix for bug
https://bugzilla.mozilla.org/show_bug.cgi?id=290499 as the only change according to
  http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/js/src/jsstr.c
has happened to fix bug 290499.

Comment 1

[Mike Shaver (:shaver emeritus)]

Do you know what the regression window is for this?

Comment 2

[Mike Shaver (:shaver emeritus)]

FWIW, I can't reproduce this on the trunk with Linux -- can you provide a stack?

Comment 3

[Martin Honnen]

(In reply to comment #2)
> FWIW, I can't reproduce this on the trunk with Linux -- can you provide a stack?

This is what I get in the debug window:

 	ntdll.dll!7c911230() 	
>	js32.dll!JS_Assert(const char * s=0x610b6f2c, const char * file=0x610b6f24,
int ln=2408)  Zeile 155	C
 	js32.dll!js_InitRuntimeStringState(JSContext * cx=0x000324c0)  Zeile 2408 + 0x22	C
 	js32.dll!js_NewContext(JSRuntime * rt=0x00033fb8, unsigned int
stackChunkSize=8192)  Zeile 165 + 0x9	C
 	js32.dll!JS_NewContext(JSRuntime * rt=0x00033fb8, unsigned int
stackChunkSize=8192)  Zeile 936 + 0xd	C
 	js.exe!main(int argc=0, char * * argv=0x00033f64, char * * envp=0x00032d68) 
Zeile 2414 + 0x11	C
 	js.exe!mainCRTStartup()  Zeile 398 + 0xe	C
 	kernel32.dll!7c816d4f() 	
 	kernel32.dll!7c8399f3() 	

The German word "Zeile" is "line" in English.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

does this also happen if you do a clean build?

Comment 5

[Martin Honnen]

(In reply to comment #4)
> does this also happen if you do a clean build?

I did a
  make -B -f Makefile.ref
to recompile everything and now the shell starts up fine.

I guess this is no bug then.

Comment 6

[Brendan Eich [:brendan]]

Makefile.ref has no auto-generated header file dependency mechanism, and I did
add a member to JSAtomState, which is embedded in JSRuntime.  For now, always
clean before rebuilding.

Rather than anyone volunteering patches to Makefile.ref, it would be better to
get a single autoconf-based build system for js/src that works standalone and in
the context of the main mozilla/-level build system.

/be