290574 - extern_id_conflict not defined in user-error template

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Simon Wilkinson]

Bugzilla::Auth::WWW:Env can throw a extern-id-conflict error, the text for which
isn't defined.

The attached patch to user-error.tmpl adds some suggested text.

Comment 1

[Simon Wilkinson]

Attachment: Suggested additon to handle the extern_id_conflict authentication error

Comment 2

[Frédéric Buclin]

Comment on attachment 180882 [details] [diff] [review]
Suggested additon to handle the extern_id_conflict authentication error

As for the other patch, you need to ask for review, else your patch will be
ignored. kiko is our authentication expert. Asking him again for review.

Thanks for the patch anyway. ;)

Comment 3

[Christian Reis]

Comment on attachment 180882 [details] [diff] [review]
Suggested additon to handle the extern_id_conflict authentication error

There's a period missing there. Maybe be more specific and say the
authentication identifier provided didn't match the identifier stored in
Bugzilla. 

Is this really a user error? I don't think so..

Comment 4

[Frédéric Buclin]

Comment on attachment 180882 [details] [diff] [review]
Suggested additon to handle the extern_id_conflict authentication error

Removing this request for review as kiko's comment seems to be a r- to me.
Reporter, can you submit an updated patch?

Comment 5

[Frédéric Buclin]

Fixed by bug 312307.