290631 - iCalendar export should include priority

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Evolution does not show any priority for the exported bug list. but, the format
would allow specifying priorities:

http://www.kanzaki.com/docs/ical/priority.html
http://www.kanzaki.com/docs/ical/vtodo.html

seems like bugzilla's priorities could be nicely mapped onto it (say, to
1/3/5/7/9 for P1-P5)

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: Patch

The spec here mentions that the numbers are restricted to 1..9, not 1..n, so I've just truncated.

Comment 2

[Frédéric Buclin]

Comment on attachment 375967 [details] [diff] [review]
Patch

>Index: buglist.cgi

>+# The iCal file needs priorities ordered from 1..n
>+{
>+    my $n = 1;
>+    $vars->{'rev_priorities'} = {};
>+    my $priorities = get_legal_field_values('priority');
>+    foreach my $p (@$priorities) {
>+        $vars->{'rev_priorities'}->{$p} = $n;
>+        $n++;
>+    }
>+}

Looks good, but this block should be enclosed in

  if ($format->{'extension'} eq 'ics') {...}

as it's used nowhere else. Also, I suggest you write the |priority > 9| logic here as well instead of in the template:

  $vars->{'rev_priorities'}->{$p} = ($n > 9) ? 9 : $n++;

Comment 3

[Bradley Baetz (:bbaetz)]

Yeah. I wanted to do it entirely in the template, but none of the helper functions are exposed and it got too messy.

Comment 4

[Bradley Baetz (:bbaetz)]

Attachment: v2

Yeah, this is cleaner.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 375980 [details] [diff] [review]
v2

Looks good to me! :-)

Comment 6

[Bradley Baetz (:bbaetz)]

Checked in:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.396; previous revision: 1.395
done
Checking in template/en/default/list/list.ics.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.ics.tmpl,v  <--  list.ics.tmpl
new revision: 1.11; previous revision: 1.10
done

Comment 7

[Max Kanat-Alexander]

Added to the release notes in bug 547466.