290635 - Spaces in extension names cause problems

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

Things are getting saved with spaces in the paths instead of having them
converted to underscores.

Comment 1

[alanjstr]

* Wolf bets $name has no str_replace(" ","_",$name); on it. :-)
Wolf: yeah, $name comes from the DB directly
Wolf: http://lxr.mozilla.org/update1.0/source/developers/inc_approval.php#25
Wolf: so, in theory, before line 40, the name needs to be cleaned up to be
filesystem directory name safe
alanjstr: or in line 40

Comment 2

[Wolf [:wolf]]

http://lxr.mozilla.org/update1.0/source/developers/inc_approval.php#40 is the
path its using. $name comes from the DB on Line 25, and needs to be cleaned up
to be filesystem safe before line 40.

$name = str_replace(" ","_",$name); before line 40 will fix the spaces in the
extension name used in the directory, though its possible other characters
that're illegal in unixy filesytems can cause issues.

Comment 3

[Steve England [:stevee]]

*** Bug 290717 has been marked as a duplicate of this bug. ***

Comment 4

[alanjstr]

Fix landed yesterday by morgamic.  
Results: 
http://stage.mozilla.org/pub/mozilla.org/extensions/install_new_theme/install_new_theme-0.4-fx.xpi