290656 - Get "TypeError: bar is not a constructor" after bug 254974

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Andrew Schultz]

If I try to watch a video on http://www.ifilm.com/, JS Console show an error,
"TypeError: LinkedListItem is not a constructor".  This started happening
sometime between linux trunk builds 2004080905 and 2004080906, so the fix for
bug 254974 looks like what changed the behavior.  I'll attach a testcase.

Comment 1

[Andrew Schultz]

Attachment: testcase

js> function foo() {
   with(foo) {
      this["insert"] = function(){ var node = new bar(); };
   }
   function bar() {}
}
js> var list = new foo();
js> list.insert();
typein:3: TypeError: bar is not a constructor

Comment 2

[Mike Shaver (:shaver emeritus)]

Requesting 1.8b2/1.1 blocking for regression.

Comment 3

[Bob Clary [:bc] (inactive)]

Checking in regress-290656.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-290656.js,v  <--  regress-290656.js
initial revision: 1.1

Comment 4

[Asa Dotzler [:asa]]

We're wrapping up 1.8b2. Is this critical for the developer preview or can we
move it to 1.8b3? 

Comment 5

[Mike Shaver (:shaver emeritus)]

I think we should block for this regression.

Comment 6

[Brendan Eich [:brendan]]

Patching in bug 293782, without regressing bug 137000 (that's the other bug to
test after the patch lands; there may be others as well, such as the bug this
bug blocks...).

/be

Comment 7

[Brendan Eich [:brendan]]

Fixed by the patch for bug 293782.

/be

Comment 8

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20060818