290703 - Mozilla Update Search butchers special characters

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Gids Goldberg]

Mozilla Update Search makes a mess of listings containing special characters
such as quote marks and ampersands.

In the case of ampersands instead of & the server sends &.
In the case of quotation marks instead of " the server sends "

Comment 1

[(not currently active) Ted Mielczarek]

Trivial to fix.  Just remove htmlspecialchars from:
http://lxr.mozilla.org/mozilla/source/webtools/update/quicksearch.php#179
Also maybe
http://lxr.mozilla.org/mozilla/source/webtools/update/quicksearch.php#175 if
extension names are already encoded in the DB.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: Drop htmlspecialchars from name/description

inc_global.php escapes all GET/POST vars by default.  Everything in the DB is
escaped already.

Comment 3

[Michael Morgan [:morgamic]]

Comment on attachment 181096 [details] [diff] [review]
Drop htmlspecialchars from name/description

An assumption either way is just that; but I'd rather see a & than &
(&) popping up in prod.  I tested this on staging and without
htmlspecialchars I did not get any validation errors.

Comment 4

[Michael Morgan [:morgamic]]

Fix will be pushed in next update.