Closed Bug 290714 Opened 16 years ago Closed 16 years ago
Don't use reserved const names in bookmarks/content
This blocks the fix for 239218.
16 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Firefox1.1
16 years ago
Summary: Don't use reserved const named in bookmarks/content → Don't use reserved const names in bookmarks/content
Attachment #180964 - Flags: review?(mconnor) → review+
Comment on attachment 180964 [details] [diff] [review] patch Requesting 1.1a approval, this one is blocking the fix for bug 239218.
Attachment #180964 - Flags: approval-aviary1.1a?
Comment on attachment 180964 [details] [diff] [review] patch a=asa
Attachment #180964 - Flags: approval-aviary1.1a? → approval-aviary1.1a+
Checking in addBookmark2.js; /cvsroot/mozilla/browser/components/bookmarks/content/addBookmark2.js,v <-- addBookmark2.js new revision: 1.34; previous revision: 1.33 done Checking in bookmarks.js; /cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v <-- bookmarks.js new revision: 1.98; previous revision: 1.97 done Checking in bookmarksManager.js; /cvsroot/mozilla/browser/components/bookmarks/content/bookmarksManager.js,v <-- bookmarksManager.js new revision: 1.19; previous revision: 1.18 done Checking in bookmarksMenu.js; /cvsroot/mozilla/browser/components/bookmarks/content/bookmarksMenu.js,v <-- bookmarksMenu.js new revision: 1.43; previous revision: 1.42 done Checking in bookmarksProperties.js; /cvsroot/mozilla/browser/components/bookmarks/content/bookmarksProperties.js,v <-- bookmarksProperties.js new revision: 1.21; previous revision: 1.20 done Checking in bookmarksTree.xml; /cvsroot/mozilla/browser/components/bookmarks/content/bookmarksTree.xml,v <-- bookmarksTree.xml new revision: 1.66; previous revision: 1.65 done Checking in selectBookmark.js; /cvsroot/mozilla/browser/components/bookmarks/content/selectBookmark.js,v <-- selectBookmark.js new revision: 1.14; previous revision: 1.13 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
This check-in appears to render the sage extension inoperative.
Well, we're about to bump the appversion for extensions, so that shouldn't be such a big deal. This is needed to enable things for Mac that were horribly broken.
Can we confirm that this *won't* go into a 1.0+ build, only into 1.1+? Just trying to figure out if hosting two extension versions based on the FF version is going to be sufficient.
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.