290714 - Don't use reserved const names in bookmarks/content

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Asaf Romano (gone)]

This blocks the fix for 239218.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Comment on attachment 180964 [details] [diff] [review]
patch

Requesting 1.1a approval, this one is blocking the fix for bug 239218.

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 180964 [details] [diff] [review]
patch

a=asa

Comment 4

[Asaf Romano (gone)]

Checking in addBookmark2.js;
/cvsroot/mozilla/browser/components/bookmarks/content/addBookmark2.js,v  <-- 
addBookmark2.js
new revision: 1.34; previous revision: 1.33
done
Checking in bookmarks.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v  <-- 
bookmarks.js
new revision: 1.98; previous revision: 1.97
done
Checking in bookmarksManager.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksManager.js,v  <--
 bookmarksManager.js
new revision: 1.19; previous revision: 1.18
done
Checking in bookmarksMenu.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksMenu.js,v  <-- 
bookmarksMenu.js
new revision: 1.43; previous revision: 1.42
done
Checking in bookmarksProperties.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksProperties.js,v 
<--  bookmarksProperties.js
new revision: 1.21; previous revision: 1.20
done
Checking in bookmarksTree.xml;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksTree.xml,v  <-- 
bookmarksTree.xml
new revision: 1.66; previous revision: 1.65
done
Checking in selectBookmark.js;
/cvsroot/mozilla/browser/components/bookmarks/content/selectBookmark.js,v  <-- 
selectBookmark.js
new revision: 1.14; previous revision: 1.13
done

Comment 5

[Bill Gianopoulos [:WG9s]]

This check-in appears to render the sage extension inoperative.

Comment 6

[Mike Connor [:mconnor]]

Well, we're about to bump the appversion for extensions, so that shouldn't be
such a big deal.  This is needed to enable things for Mac that were horribly broken.

Comment 7

[Paul Roub]

Can we confirm that this *won't* go into a 1.0+ build, only into 1.1+?  Just
trying to figure out if hosting two extension versions based on the FF version
is going to be sufficient.

Comment 8

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change