290760 - Developers should not be able to review their own extensions

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

An Editor should not be able to review their own submissions.  But an Admin
should still not be restricted.

Comment 1

[Colin Ogilvie [:cso]]

Attachment: Patch v1

This patch disables all the options on a bug that the user has authored (or
co-authored).

Comment 2

[alanjstr]

1) Can you maybe do a TR background of light gray
2) You just need to force it to "No Action".  You don't need to disable every
field.  That should make for a smaller patch.

Comment 3

[Colin Ogilvie [:cso]]

(In reply to comment #2)
> 1) Can you maybe do a TR background of light gray

Probably...

> 2) You just need to force it to "No Action".  You don't need to disable every
> field.  That should make for a smaller patch.

Personal opinion is that I like the things there to be disabled, but I'll defer
to others on their opinion.

Comment 4

[alanjstr]

I almost suggested hiding the row, but that wouldn't be good because then the
rowcount wouldn't match the sidebar.

Although, from a security standpoint, just disabling the fields in inadequate. 
The check should actually be in the script that does the updates.

Comment 5

[Michael Morgan [:morgamic]]

Comment on attachment 181045 [details] [diff] [review]
Patch v1

tested; worked fine.  Committed this along with bug 290871.

Comment 6

[Michael Morgan [:morgamic]]

Landed, will be pushed in next update.