290761 - calIDateTime: rename valid to isValid

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: trunk

Most of the boolean properties are named isXXX, such as 
  isMutable
  isDate
  isUTC

Suggest that calIDateTime.valid should be calIDateTime.isValid

(Consistency is more important when there is no name-checking compiler, as in
javascript.)

Reproducible: Always

Steps to Reproduce:

Comment 1

[Mike Shaver (:shaver emeritus)]

Agreed; Vlad, if you also agree, can you make it so?

Comment 2

[gekacheka]

Attachment: rename calIDateTime.valid to calIDateTime.isValid

(patch -l -p 2 -i file.patch)

patches 
  .valid to .isValid
  GetValid to GetIsValid
in
  mozilla/calendar/base/public/calIDateTime.idl
  mozilla/calendar/base/src/calDateTime.cpp
  mozilla/calendar/base/src/calICSService.cpp
  mozilla/calendar/base/src/calItemBase.js
  mozilla/calendar/providers/caldav/calDavCalendar.js
  mozilla/calendar/providers/memory/calMemoryCalendar.js
  mozilla/calendar/resources/content/eventDialog.js

(untested)

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 182277 [details] [diff] [review]
rename calIDateTime.valid to calIDateTime.isValid

asking review from a specific person is generally prefered...

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 182277 [details] [diff] [review]
rename calIDateTime.valid to calIDateTime.isValid

r=vladimir, I assume that's all the uses of .valid in the calendar tree?

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

You missed a couple of spots (mValid -> mIsValid)