Closed Bug 290781 Opened 20 years ago Closed 19 years ago

Minimo has hardcoded UA string and so version and Gecko string

Categories

(Minimo Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Future

People

(Reporter: aha, Assigned: dougt)

References

()

Details

Attachments

(1 file)

It looks like Minimo has preference to force static user-agent string, so
version  or Gecko string doesn't update:

http://lxr.mozilla.org/mozilla/source/embedding/minimo/all.js#90

90 pref("general.useragent.override", "Mozilla/5.0 (X11; U; Familiar 0.72;
en-US; rv:1.7a) Gecko/20040218 Minimo/0.1");
Attached patch http ua patchSplinter Review
This patch makes us construct a UA string that looks something like:

Mozilla/5.0 (Windows CE; U; Windows CE 4.20; rv:1.8b3) Gecko/20050720
<product>/<productSub>

This is a window ce only change.
Attachment #189918 - Flags: review?(darin)
Attachment #189918 - Flags: review?(darin) → review+
in the patch, for my changes, s/#else/#elif
Comment on attachment 189918 [details] [diff] [review]
http ua patch

sr=dveditz if you fix the #else/#elif problem
Attachment #189918 - Flags: review+
For WinCE:

Checking in nsHttpHandler.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpHandler.cpp,v  <-- 
nsHttpHandler.cpp
new revision: 1.114; previous revision: 1.113
done


I have also changed the UA string for WINCE to:
pref("general.useragent.extra.minimo", "Minimo/0.007");

Checking in all.js;
/cvsroot/mozilla/embedding/minimo/wince/all.js,v  <--  all.js
new revision: 1.9; previous revision: 1.8
done


leaving open for Linux changes.
OS: Windows XP → Linux
Target Milestone: --- → Future
Assignee: dougt → nobody
minimo on linux now uses the same code as minimo ce.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee: nobody → doug.turner
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: