290793 - bookmarks menu doesn't scroll with the keyboard

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Caleb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050417 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050417 Firefox/1.0+

It looks like the Bookmarks menu does not follow the keyboard arrow keys up/down.

To reproduce:

1. Open the Bookmarks menu
2. Press the "UP" keyboard arrow

The menu should select and scroll to the last item, but instead it only selects,
without scrolling to it.

Note: you need alot of bookmarks to reproduce.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Martijn Wargers (dead)]

Works with 2005-04-03 trunk build, fails with 2005-04-04 trunk build:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-04-03+06%3A00%3A00&maxdate=2005-04-04+08%3A00%3A00&cvsroot=%2Fcvsroot

Comment 2

[Boris Zbarsky [:bzbarsky]]

Given that range, could this be the scrollframe changes?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

More code that just sort of randomly pokes around looking for a scrollable view
:-(

Comment 4

[Jim Ginn]

*** Bug 291430 has been marked as a duplicate of this bug. ***

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 184041 [details] [diff] [review]
fix

fixes a UI regression

Comment 6

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184041 [details] [diff] [review]
fix

a=shaver

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 8

[Peter van der Woude [:Peter6]]

Attachment: livebookmark testcase

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050602
Firefox/1.0+ ID:2005060202

Does not work with live bookmarks

->REOPENING

repro:
create a new livebookmark with the attached feed (200 items long)
try to scroll it in bookmarks menu

Comment 9

[Peter van der Woude [:Peter6]]

my bad, restarted and it worked again