290802 - Emails sent from the server to the developer upon acceptance or denial not sent.

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[neilp]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.6) Gecko/20050321 Firefox/1.0.2 StumbleUpon/1.9993
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.6) Gecko/20050321 Firefox/1.0.2 StumbleUpon/1.9993

When a new extension is posted on umo and a moderator accepts or denies an
extension, an email is supposed to be produced to the developer informing them.
Currently no email is received.

Reproducible: Always

Steps to Reproduce:
1. Add a new extension to umo
2. get the new extension approved
3. wait for an email
4. remove the test extension from umo

Actual Results:  
no email was received in step (3).

Expected Results:  
sent an email

I can't reproduce this without filling up the umo database to properly
reproduce, sorry.

Comment 1

[Colin Ogilvie [:cso]]

I've found the cause of this, patch will be forthcoming.

Comment 2

[Colin Ogilvie [:cso]]

Attachment: Patch v1

Patch v1

This changes the email column name to be "UserEmail" as it is in the database.
This should fix the bug.

Comment 3

[alanjstr]

Why isn't it throwing an error?  We really need to stop suppressing these things.

Comment 4

[Colin Ogilvie [:cso]]

because the include line is @include which surpresses error messages. I found
this by taking the @ out and enabling errors.

Comment 5

[Michael Morgan [:morgamic]]

Comment on attachment 181027 [details] [diff] [review]
Patch v1

Landed this, without the unnecessary double quotes for $row['UserEmail'].  :)

Thanks, Colin.

Comment 6

[Colin Ogilvie [:cso]]

Resolving FIXED per morgamic's comment.