290812 - Problems with firefox built from trunk

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

I've just built firefox and an xforms.xpi from trunk, and there seems to be a
problem with xforms.properties. When I trigger an XForms error message, I get
this message on the JavaScript console once:
"No chrome package registered for chrome://xforms/locale/xforms.properties"

Comment 1

[aaronr]

Can you verify this bug again Allan?  Seems to work ok on a firefox build I did
on Windows on 15/05.  Thanks.

Comment 2

[Allan Beaufour]

(In reply to comment #1)
> Can you verify this bug again Allan?  Seems to work ok on a firefox build I did
> on Windows on 15/05.  Thanks.

Still there, on a build from this morning.

Comment 3

[Allan Beaufour]

Attachment: Testcase

Loading this form shows the "no chrome..." error from above, and:
nsXFormsModelElement::Rebuild()
nsXFormsModelElement::Recalculate()
nsXFormsModelElement::Revalidate()
nsXFormsUtils::ReportError() Failed to get message string for message id
'idRefError'!
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsXFormsUtils.cpp, line
490
WARNING: NS_ENSURE_TRUE(mModel) failed, file nsXFormsControlStub.cpp, line 228
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsStringBundle.cpp, line
273
nsXFormsUtils::ReportError() Failed to get message string for message id
'controlBindError'!

Comment 4

[aaronr]

doron said that he's got some time to look at this.  I didn't see this with my
Firefox build running with the XBL patches.

Comment 5

[Doron Rosenberg (IBM)]

I can reproduce this

Comment 6

[Doron Rosenberg (IBM)]

Attachment: patch

Simple - install.rdf is missing the locale registration section.

Comment 7

[Doron Rosenberg (IBM)]

I also bumped the version of the XPI to 0.2

Comment 8

[Allan Beaufour]

(In reply to comment #7)
> I also bumped the version of the XPI to 0.2

While we're at it how about setting maxVersion to 1.1 instead of 1.0+? Or is
that not allowed?

Comment 9

[Allan Beaufour]

Comment on attachment 185064 [details] [diff] [review]
patch

I do not know enough about extensions to say whether it is a correct fix, but
it fixes the bug.

r=me, but consider the maxVersion too

Comment 10

[Allan Beaufour]

(In reply to comment #7)
> I also bumped the version of the XPI to 0.2

You need to set PACKAGE_VERSION in Makefile.in too.

I tried to make it is as generic as possibly in bug 285418, but install.rdf
still needs to be modified and possibly other places too. Please check.

Comment 11

[Doron Rosenberg (IBM)]

Attachment: with allan's changes

Bumped maxVersion and the makefile.

The reason the patch works is that you need to tell it what dirs in the jar
need to be registered, and we are missing the locales directory

Comment 12

[Doron Rosenberg (IBM)]

checked in.