290829 - place holders in helper app dialog are not replaced

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Michael Lampe]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041220
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041220

Click on a link to a file whose mime type mozilla does not kow. You get a box
saying:

---
Opening #1

The file "#3" is of type #2 (#1), and #4 does not know how to handle this file
type ...
---

Does not happen with 1.7.5 but with 1.7.[67]


Reproducible: Always

Steps to Reproduce:
1. Click on link to a file whose mime type mozilla does not kow

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

are any errors shown in tools|web development|javascript console?

Comment 2

[Michael Lampe]

Error: uncaught exception: [Exception... "Component returned failure code:
0x8000ffff (NS_ERROR_UNEXPECTED) [nsIURI.userPass]"  nsresult: "0x8000ffff
(NS_ERROR_UNEXPECTED)"  location: "JS frame ::
file:///home/lampe/T/mozilla/components/nsHelperAppDlg.js :: anonymous :: line
242"  data: no]

Error: _timer is not defined
Source File: file:///home/lampe/T/mozilla/components/nsHelperAppDlg.js
Line: 381

Error: _timer is not defined
Source File: file:///home/lampe/T/mozilla/components/nsHelperAppDlg.js
Line: 381

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

hm.. what kind of URL was that? a normal http:// one?

Comment 4

[Michael Lampe]

It was a file://... URL. Just checked that with http://... the problem does not
exist. But then again 1.7.5 got it always right.

Comment 5

[Andrew Schultz]

Confirmed with linux builds 1.7.{6,7}.  Current trunk works fine.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_7_BRANCH&branchtype=match&dir=&file=nsHelperAppDlg.js&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-12-17&maxdate=2005-03-19+08%3A00%3A00&cvsroot=%2Fcvsroot

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

caused by neil in bug 285163, the assignment to userPass should be in a try..catch

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

ah. this works on trunk because of bug 268480 (see also bug 268480 comment 2)

Comment 8

[Daniel Veditz [:dveditz]]

bug 268480 only patched nsStandardURL, simple urls like data: are still broken
on the trunk. Copy/paste the following into the location bar, then click the link:

data:text/html,<a href="data:foo/bar,blahblahblah">clickme</a>

Not that it's all that useful a technique, but this should still be patched on
the trunk and not just the branch.

Comment 9

[[e-mail]]

Attachment: Proposed patch

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 181208 [details] [diff] [review]
Proposed patch

sr=dveditz

Created bug 291064 for the related problem in Firefox.

Comment 11

[[e-mail]]

Comment on attachment 181208 [details] [diff] [review]
Proposed patch

Low-risk regression fix to ignore the error clearing passwords on urls that
don't support them.

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 181208 [details] [diff] [review]
Proposed patch

a=asa for 1.8b2 checkin.

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 295363 has been marked as a duplicate of this bug. ***

Comment 14

[Daniel Veditz [:dveditz]]

Was this ever checked into the trunk?

Comment 15

[timeless]

Comment on attachment 181208 [details] [diff] [review]
Proposed patch

2005-04-20 10:06
mozilla/embedding/components/ui/helperAppDlg/nsHelperAppDlg.js	1.67

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 297339 has been marked as a duplicate of this bug. ***

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 297627 has been marked as a duplicate of this bug. ***

Comment 18

[Daniel Veditz [:dveditz]]

Comment on attachment 181208 [details] [diff] [review]
Proposed patch

a=dveditz for the branch. Land soon if you're going to.

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

MOZILLA_1_7_BRANCH:
Checking in embedding/components/ui/helperAppDlg/nsHelperAppDlg.js;
/cvsroot/mozilla/embedding/components/ui/helperAppDlg/nsHelperAppDlg.js,v  <--
nsHelperAppDlg.js
new revision: 1.55.2.3; previous revision: 1.55.2.2
done


Aviary branch does not have the checkin that caused it. Also, Firefox does not
use this file (I'm unsure whether thunderbird does...)

Comment 20

[Daniel Veditz [:dveditz]]

clearing 1.0.5 flag per last comment