Closed
Bug 290850
Opened 20 years ago
Closed 20 years ago
BUILD_ID uses $(shell) poorly
Categories
(Firefox Build System :: General, defect, P1)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: benjamin, Assigned: darin.moz)
Details
Attachments
(1 file)
|
753 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
At the last line of config.mk, there is DEFINES += -DBUILD_ID=$(shell cat $(DEPTH)/config/build_number) Which is a very poor use of $(shell) because it evaluates and launches a sub-process every time DEFINES is used in a makefile. It should instead use an intermediate immediate-evaluation var so that we only `cat` once.
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta2
|
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #181094 -
Flags: review?(benjamin)
|
Reporter | |
Updated•20 years ago
|
Attachment #181094 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 2•20 years ago
|
||
Comment on attachment 181094 [details] [diff] [review] v1 patch trivial change, no risk.
Attachment #181094 -
Flags: approval1.8b2?
Attachment #181094 -
Flags: approval1.8b2? → approval1.8b2+
|
||
Comment 3•20 years ago
|
||
Comment on attachment 181094 [details] [diff] [review] v1 patch a=caillon
|
|
Assignee | |
Comment 4•20 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•