290905 - windows makeall.pl incorrectly sets $topobjdir

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect, P1)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

70 $topobjdir                = "$topsrcdir"                 if
!defined($topobjdir);

This doesn't work if you have a separate objdir.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 181107 [details] [diff] [review]
patch

You're assuming that the cwd() of the call is
<objdir>/xpinstall/packager/windows? Why is that a safe assumption?

Comment 3

[Benjamin Smedberg]

Comment on attachment 181107 [details] [diff] [review]
patch

Marking r- per IRC conversation... just pass -objdir from the makefile.

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: new patch

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

I think this also fixes bug 243616.

Comment 6

[Benjamin Smedberg]

Comment on attachment 181646 [details] [diff] [review]
patch

r=me, no sr needed for simple build config changes like this.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 181646 [details] [diff] [review]
patch

a=asa

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

checked in